Skip to content

Conversation

@siliu1
Copy link
Contributor

@siliu1 siliu1 commented May 23, 2024

Per issue #10345, We should change the API signature from document.caretPositionFromPoint(double x, double y, ShadowRoot... shadowRoots) to document.caretPositionFromPoint(double x, double y, optional CaretPositionFromPointOptions options = {}) where CaretPositionFromPointOptions is defined as:

dictionary CaretPositionFromPointOptions {
  sequence<ShadowRoot> shadowRoots = [];
};

@siliu1 siliu1 changed the title [cssom-view] Change document.caretPositionFromPoint's shadowRoots parameter from rest parameter to a dictionary with an array of shadow roots [cssom-view] Change document.caretPositionFromPoint's shadowRoots parameter from rest parameter to a dictionary with an array of shadow roots May 23, 2024
@siliu1 siliu1 requested a review from sanketj May 24, 2024 15:48
@siliu1 siliu1 marked this pull request as ready for review May 28, 2024 18:22
@siliu1 siliu1 requested a review from zcorpan May 28, 2024 19:20
@siliu1
Copy link
Contributor Author

siliu1 commented May 30, 2024

@zcorpan Please take a look. Thank you.

@siliu1 siliu1 requested a review from emilio June 4, 2024 16:51
@siliu1
Copy link
Contributor Author

siliu1 commented Jun 4, 2024

@emilio Please take a look. Thank you!

@emilio emilio merged commit ce0c83b into w3c:main Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants