[css-contain][css-conditional] Move container queries from contain-3 to conditional-5 #10447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbaron
approved these changes
Jun 14, 2024
| @@ -64,6 +94,11 @@ Introduction</h2> | |||
| such that only the first matching rule in a [=conditional rule chain=] | |||
| is applied. | |||
|
|
|||
| It also adds Container Queries. | |||
There was a problem hiding this comment.
I would suggest changing the order of the description of the three new pieces (font technology queries, @when/@else, and Container Queries) of the introduction. Specifically:
-
I think the bit about querying for supported font technologies should be last, since it's probably the smallest both in scope and size.
-
I think the addition of container queries could optionally be before the introduction of
@whenand@elsesince I think CQ is a more significant feature but@when/@elsecould perhaps be described as having broader scope over the features of the module, so I could see describing these in either order.
dbaron
reviewed
Jun 14, 2024
dbaron
approved these changes
Jun 17, 2024
frivoal
added a commit
to frivoal/wpt
that referenced
this pull request
Jun 28, 2024
frivoal
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 28, 2024
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Jul 9, 2024
…estonly Automatic update from web-platform-tests Move tests to match the spec's move See w3c/csswg-drafts#10447 -- wpt-commits: c6273f7c688e8e62356f2a0a6e388108d58042ef wpt-pr: 46928
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jul 9, 2024
…estonly Automatic update from web-platform-tests Move tests to match the spec's move See w3c/csswg-drafts#10447 -- wpt-commits: c6273f7c688e8e62356f2a0a6e388108d58042ef wpt-pr: 46928
sadym-chromium
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #10433
This PR makes no change to the normative text, just moves it, and adjusts the relevant abstracts/introductions/changelogs/…