-
Notifications
You must be signed in to change notification settings - Fork 757
[cssom-view-1] Added definition of getBoxQuads() #10538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
e91afa6
57dc349
db85f76
1adcbdd
064b981
75d652d
00fe074
6d537f3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1861,46 +1861,74 @@ Document includes GeometryUtils; | |
| typedef (Text or Element or CSSPseudoElement or Document) GeometryNode; | ||
| </pre> | ||
|
|
||
| The <dfn method for=GeometryUtils lt="getBoxQuads(options)|getBoxQuads()">getBoxQuads(<var>options</var>)</dfn> method must run the following steps: | ||
|
|
||
| The helper method getCompleteTransform(node, anchestor) must run the following steps: | ||
| <ol> | ||
| <li class=issue> | ||
| DOM order | ||
|
|
||
| p1 = top left even in RTL | ||
|
|
||
| scale to 0 means divide by zero, return 0x0 | ||
|
|
||
| cross-frames not allowed, throw WrongDocumentError? | ||
|
|
||
| points are flattened (3d transform), z=0. like getClientRect | ||
|
|
||
| test block in inline | ||
| 1. let currentElement be node. | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. currentNode, right? I think this should use |
||
| 2. let transformationMatrix be the current transformation matrix of currentElement (https://www.w3.org/TR/css-transforms-2/#ctm) | ||
| 3. while currentElement is not null do | ||
| <ol> | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do you really need the |
||
| 1. create a translation matrix from the currentElement offsetLeft and offsetTop | ||
| 2. multiply the matrix from 4. with the transformationMatrix and store the result in transformationMatrix | ||
| 3. assign the offsetParent of currentElement to currentElement | ||
| 4. let parentTransformationMatrix be the current transformation matrix of currentElement (https://www.w3.org/TR/css-transforms-2/#ctm) | ||
| 5. multiply the parentTransformationMatrix with the transformationMatrix and store in transformationMatrix | ||
| 6. if currentElement is the anchestor or the anchestor is null return the transformationMatrix | ||
| </ol> | ||
| </ol> | ||
|
|
||
| pseudo-elements before/after are children of the element | ||
| The <dfn method for=GeometryUtils lt="getBoxQuads(options)|getBoxQuads()">getBoxQuads(<var>options</var>)</dfn> method must run the following steps: | ||
|
|
||
| viewport boxes are all the same | ||
| <ol> | ||
| 1. create an array as result container | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| 2. for each css-fragment of the element run the following steps | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. of what element? Probably of |
||
| <ol> | ||
| 1. Create a DOMRect of the Element with the x,y value of 0 and the offsetWith and offsetHeight. | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This doesn't seem right,
|
||
| 2. Depending on the value of options.box modify the Rect from 1. with the calculated style values of the element. | ||
| - 'border': no change | ||
| - 'margin': https://drafts.csswg.org/css-box-4/#box-edges - use the margin-box | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should not just drop the urls like this, it should link to the definition. |
||
| - 'padding': https://drafts.csswg.org/css-box-4/#box-edges - use the padding-box | ||
| - 'content': https://drafts.csswg.org/css-box-4/#box-edges - use the content-box | ||
| 3. create a DomQuad from the rect via DOMQuad.fromRect | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Proper capitalization |
||
| 4. Calculate the resulting transformation matrix between the element and options.realtiveTo (if relativeTo is unset use window.defaultView) via the algorithm defined in getCompleteTransform | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
This should be untransforming the rect to the layout viewport if there's no |
||
| 5. transform every Point of the quad via the matrix calculated in 4. and add the result to the result container | ||
| </ol> | ||
| 3. return the result container | ||
| </ol> | ||
|
|
||
| The <dfn method for=GeometryUtils lt="convertQuadFromNode(quad, from, options)|convertQuadFromNode(quad, from)">convertQuadFromNode(<var>quad</var>, <var>from</var>, <var>options</var>)</dfn> method | ||
| must run the following steps: | ||
|
|
||
| <ol> | ||
| <li><p class=issue>... | ||
| 1. transform each point of the DOMQuad via convertPointFromNode | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should link to |
||
| </ol> | ||
|
|
||
| The <dfn method for=GeometryUtils lt="convertRectFromNode(rect, from, options)|convertRectFromNode(rect, from)">convertRectFromNode(<var>rect</var>, <var>from</var>, <var>options</var>)</dfn> method | ||
| must run the following steps: | ||
|
|
||
| <ol> | ||
| <li><p class=issue>... | ||
| 1. create a DOMQuad from the rect via DOMQuad.fromRect | ||
| 2. transform each point of the DOMQuad from 1. via convertPointFromNode | ||
| </ol> | ||
|
|
||
| The <dfn method for=GeometryUtils lt="convertPointFromNode(point, from, options)|convertPointFromNode(point, from)">convertPointFromNode(<var>point</var>, <var>from</var>, <var>options</var>)</dfn> | ||
| method must run the following steps: | ||
|
|
||
| <ol> | ||
| <li><p class=issue>... | ||
| 1. get the resulting matrix between the node and the document.defaultView via the algorithm defined in getCompleteTransform | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Give these meaningful names like: Then reference those. |
||
| 2. get the resulting matrix between the from and the document.defaultView via the algorithm defined in getCompleteTransform | ||
| 3. inverse the matrix in 2. | ||
| 4. Depending on the value of options.fromBox modify the point with the calculated style values of the element. | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should use |
||
| - 'border': no change | ||
| - 'margin': x - margin.left, y - margin.top | ||
| - 'padding': x + border.leftWidth, y + border.topWidth | ||
| - 'content': x + border.leftWidth + padding.left, y + border.topWidth + padding.top | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is not actually based on the computed style but on the actual used padding box etc. Those boxes are defined already elsewhere and we should reuse the definitions. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't really find where I should link to. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Pretty sure those boxes are defined here: https://drafts.csswg.org/css-box-4/#box-edges There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, but I need to link to the Algorythm how they are calculated, or is this enough? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There is no algorithm like that for these. They are defined in English instead. Browsers have algorithms internally that match those descriptions and can call into those when a spec says to do something with one of these boxes, so linking to their definitions is enough to unambiguously tell an implementer what needs to happen. More modern specs like to define their concepts in terms of algorithms to derive them, because that makes implementation easier and leaves less room for creative (mis-)interpretation of the definition. TL;DR: You want to link to a concept's definition when using it. Whether that is an algorithm or not doesn't matter. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same, refer to standard terms. It seems |
||
| 5. transform the point from 4. with the matrix in 1. | ||
| 6. transfrom the point from 5. with the matrix in 2. | ||
| 7. Depending on the value of options.toBox modify the point from 6. with the calculated style values of the element. | ||
| - 'border': no change | ||
| - 'margin': x + margin.left, y + margin.top | ||
| - 'padding': x - border.leftWidth, y - border.topWidth | ||
| - 'content': x - border.leftWidth - padding.left, y - border.topWidth - padding.top | ||
| </ol> | ||
|
|
||
| <h2 id=visualViewport>VisualViewport</h2> | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should probably add a
<dfn>so that you can reference this properly elsewhere.