[css-viewport] Define the viewport property in window#10548
Merged
Conversation
In preparation to add the segments property we need to make sure that the viewport property is properly specified. This patch already adds the zoom property to the viewport interface as it was already defined.
9abeb26 to
edd88b7
Compare
Contributor
Author
|
I wasn't entirely sure about the |
Contributor
|
I don’t think |
Contributor
Oops, I didn't read this PR carefully enough. Indeed, it's not a property. I'll revert this PR. |
chrishtr
added a commit
that referenced
this pull request
Jul 12, 2024
Contributor
|
Rest of the PR looks good, though. |
Contributor
Author
|
I could have just reverted the IDL. |
Contributor
|
I think it'd be better to just redo the PR. I'll review it promptly. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation to add the segments property we need to make sure that the viewport property is properly specified. This patch already adds the zoom property to the viewport interface as it was already defined.