Skip to content

[css-fonts-4] Restore monospace in generic family#10559

Merged
svgeesus merged 1 commit into
w3c:mainfrom
cdoublev:patch-2
Jul 14, 2024
Merged

[css-fonts-4] Restore monospace in generic family#10559
svgeesus merged 1 commit into
w3c:mainfrom
cdoublev:patch-2

Conversation

@cdoublev
Copy link
Copy Markdown
Collaborator

Following 69f7f7a, I think <generic-complete> is missing monospace.

@cdoublev cdoublev added the css-fonts-4 Current Work label Jul 12, 2024
@svgeesus svgeesus merged commit ee108d0 into w3c:main Jul 14, 2024
@svgeesus
Copy link
Copy Markdown
Contributor

Thanks!

@cdoublev cdoublev deleted the patch-2 branch July 14, 2024 19:14
@cdoublev
Copy link
Copy Markdown
Collaborator Author

@svgeesus, I cannot see the change live. The spec build after the commit failed with Error: The operation was canceled.. There was a successful build from another commit (also for CSS Fonts 4) a few minutes later though. Do you know how to fix this problem?

@svgeesus
Copy link
Copy Markdown
Contributor

Thanks for noticing! That is so odd. The commit shows up in the history but has a red x.

I have fixed it by re-applying that small change, but sure would like to know how it failed in the first place.

@cdoublev
Copy link
Copy Markdown
Collaborator Author

My mistake: I edited the commented (hidden) version of the production.

<!-- <pre class=prod>
    ...
    <dfn><<generic-complete>></dfn> = serif | sans-serif | system-ui | cursive | fantasy | math

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

css-fonts-4 Current Work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants