Skip to content

Conversation

@flackr
Copy link
Contributor

@flackr flackr commented Jul 24, 2024

This changes the scroll marker primitive to be based on a regular element within a focusgroup allowing multiple groups of markers to be created and leaning on the focusgroup proposal to establish the interaction behavior.

This changes the scroll marker primitive to be based on a regular <a> element within a focusgroup.
@flackr flackr requested a review from tabatkins July 24, 2024 20:23
Copy link
Member

@tabatkins tabatkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nits, but otherwise looks good.

@flackr flackr requested a review from tabatkins July 30, 2024 17:20
Copy link
Member

@tabatkins tabatkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some spelling/markup nits you can accept edits on, then good to merge 👍

Co-authored-by: Tab Atkins Jr. <jackalmage@gmail.com>
@flackr flackr merged commit eac9300 into w3c:main Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants