[css-color-4] #10695 Fix rgbToHwb to use subset of rgbToHsl that only computes the hue #10718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nly computes the hue Tests related to out-of-gamut relative colors [css-color-5] already implicitly match the corrected behavior.
2c742a2 to
bac2542
Compare
svgeesus
approved these changes
Aug 9, 2024
squelart
added a commit
to squelart/WebKit
that referenced
this pull request
Aug 9, 2024
…algorithm https://bugs.webkit.org/show_bug.cgi?id=277538 rdar://133045692 Reviewed by NOBODY (OOPS!). The suggested rgbToHwb algorithm at https://drafts.csswg.org/css-color-4/#rgb-to-hwb used to use rgbToHsl to compute the hue, discarding the saturation and lightness. But rgbToHsl special-cases negative saturations (possible with out-of-gamut colors), and flips the hue in that case, resulting in incorrect out-of-gamut HWB values. This was fixed in w3c/csswg-drafts#10718 This patch here replicates w3c/csswg-drafts#10718 in the equivalent WebKit function, it fixes failures in relative-color-out-of-gamut-expected.html, but also in color-mix-out-of-gamut-expected.html. * LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-mix-out-of-gamut-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/relative-color-out-of-gamut-expected.txt: * Source/WebCore/platform/graphics/ColorConversion.cpp: (WebCore::ExtendedSRGBA<float>>::convert):
webkit-commit-queue
pushed a commit
to squelart/WebKit
that referenced
this pull request
Aug 11, 2024
…algorithm https://bugs.webkit.org/show_bug.cgi?id=277538 rdar://133045692 Reviewed by Tim Nguyen. The suggested rgbToHwb algorithm at https://drafts.csswg.org/css-color-4/#rgb-to-hwb used to use rgbToHsl to compute the hue, discarding the saturation and lightness. But rgbToHsl special-cases negative saturations (possible with out-of-gamut colors), and flips the hue in that case, resulting in incorrect out-of-gamut HWB values. This was fixed in w3c/csswg-drafts#10718 This patch here replicates w3c/csswg-drafts#10718 in the equivalent WebKit function, it fixes failures in relative-color-out-of-gamut-expected.html, but also in color-mix-out-of-gamut-expected.html. * LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-mix-out-of-gamut-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/relative-color-out-of-gamut-expected.txt: * Source/WebCore/platform/graphics/ColorConversion.cpp: (WebCore::ExtendedSRGBA<float>>::convert): Canonical link: https://commits.webkit.org/282101@main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests related to out-of-gamut relative colors [css-color-5] already implicitly match this corrected behavior.