[selectors-4] Fix bikeshed warnings #10750
Conversation
kbabbitt
commented
Aug 17, 2024
- Add link-defaults for two definitions
- Fix numerous "Ambiguous for-less link" warnings
- Convert spaces to tabs on line 1980
- Tag var 'argument' with 'ignore' where it's used in a Note
| It represents a set of simultaneous conditions | ||
| on a set of elements in the particular relationships | ||
| described by its <a>combinators</a>. | ||
| described by its <a for=selector>combinators</a>. |
There was a problem hiding this comment.
For this particular edit, the warning is fixed, but for some reason it's still not link-ifying, and I'm not sure why.
There was a problem hiding this comment.
Oh, it works just fine, it's just that, in order to reduce visual clutter in heavily linked text, Bikeshed suppresses instances of a given autolink past the first in a given paragraph. (We tried to just visually reduce the contrast, but that was nixed by a11y people, so instead of "this link exists, but it's intentionally a little hard to distinguish from surrounding text" we just have "this link doesn't exist at all" now. :( )
|
@tabatkins / @fantasai friendly ping on this PR. Any concerns with the changes, or any idea why the edit I commented on might not be link-ifying properly? |