[css-view-transitions] Rename UpdateCallback to something more specific. #10767
+22
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The WebIDL namespace is global, it's a bit better if we call this something a bit more view-transitions-specific so that other specs don't rely on it, since UpdateCallback is otherwise very generic. I don't think this would be a normative change since the name of a callback isn't exposed anywhere author visible.
|
cc @nt1m in case there's any objection :) |
nt1m
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
I think this is fine:
- WebKit already names this
ViewTransitionUpdateCallback: https://searchfox.org/wubkat/source/Source/WebCore/dom/ViewTransitionUpdateCallback.idl - Chrome names this
ViewTransitionCallback: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/view_transition/view_transition_callback.idl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WebIDL namespace is global, it's a bit better if we call this something a bit more view-transitions-specific so that other specs don't rely on it, since UpdateCallback is otherwise very generic.
I don't think this would be a normative change since the name of a callback isn't exposed anywhere author visible.