Skip to content

Conversation

@lilles
Copy link
Member

@lilles lilles commented Aug 28, 2024

Per resolution in [1], add scroll-state() as a query function to query sticky, snap, and overflow scroll states with a new container-type for scroll-state queries.

[1] #6402 (comment)

Per resolution in [1], add scroll-state() as a query function to query
sticky, snap, and overflow scroll states with a new container-type for
scroll-state queries.

[1] w3c#6402 (comment)
@lilles lilles requested a review from dbaron August 28, 2024 11:11
Copy link
Member

@dbaron dbaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable. One big question at the top (about whether it's supposed to be in this file at all), and then a bunch of specific comments on the text.

@lilles lilles requested a review from fantasai August 29, 2024 08:49
Copy link
Contributor

@svgeesus svgeesus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall approve, as I prefer to see good PR merged sooner and details worked out later. But I will wait for one of the other editors to do the merge. Not all of the @dbaron comments have been resolved.

@lilles
Copy link
Member Author

lilles commented Sep 3, 2024

Overall approve, as I prefer to see good PR merged sooner and details worked out later. But I will wait for one of the other editors to do the merge. Not all of the @dbaron comments have been resolved.

Thanks!

@svgeesus
Copy link
Contributor

svgeesus commented Sep 3, 2024

@dbaron are you now satisfied with the responses to your helpful comments on this PR? If so please r+

Copy link
Member

@dbaron dbaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left four new comments (two of which show up directly above, and two of which only show up in the middle of the earlier threads), but I'm fine with this landing either in its current state or with an attempt to address those.

@lilles lilles merged commit 9468285 into w3c:main Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants