Skip to content

[css-view-transitions-1] Swap the order between setting the phase and calling the update callback #10826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
noamr merged 3 commits into from
Sep 5, 2024
Merged

[css-view-transitions-1] Swap the order between setting the phase and calling the update callback #10826

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d32091
[css-view-transitions-1] Swap the order between setting the phase and…
noamr Sep 3, 2024
0318768
Change order around
noamr Sep 4, 2024
4d25465
Change order around
noamr Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change order around
  • Loading branch information
@noamr
noamr committed Sep 4, 2024
commit 0318768278cd9974b1755d5c2526b5371b19185c
4 changes: 2 additions & 2 deletions css-view-transitions-1/Overview.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1600,12 +1600,12 @@ urlPrefix: https://wicg.github.io/navigation-api/; type: interface;

1. Let |callbackPromise| be null.

1. If |transition|'s [=ViewTransition/phase=] is not "`done`", then set |transition|'s [=ViewTransition/phase=] to "`update-callback-called`".
Copy link
Copy Markdown
Collaborator

@emilio emilio Sep 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May as well move it further up to keep the code using callbackPromise together?

Copy link
Copy Markdown
Collaborator Author

@noamr noamr Sep 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, done


1. If |transition|'s [=ViewTransition/update callback=] is null,
then set |callbackPromise| to [=a promise resolved with=] undefined,
in |transition|'s [=relevant Realm=].

1. If |transition|'s [=ViewTransition/phase=] is not "`done`", then set |transition|'s [=ViewTransition/phase=] to "`update-callback-called`".

1. Otherwise, set |callbackPromise| to the result of [=/invoking=] |transition|'s [=ViewTransition/update callback=].
Copy link
Copy Markdown
Member

@nt1m nt1m Sep 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is "otherwise" here correct?

Copy link
Copy Markdown
Collaborator Author

@noamr noamr Sep 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, fixed


1. Let |fulfillSteps| be to following steps:
Expand Down