Skip to content

[css-font-4][editorial] Fix <'font'> syntax, simplify <font-variant-css2> and <font-width-css3> syntaxes #10832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

lahmatiy
Copy link
Contributor

@lahmatiy lahmatiy commented Sep 4, 2024

According to the CSS Values and Units specification as stated:

If the property’s value grammar is a comma-separated repetition, the corresponding type does not include the top-level comma-separated list multiplier. (E.g. if a property named pairing is defined as [ <custom-ident> <integer>? ]#, then <'pairing'> is equivalent to [ <custom-ident> <integer>? ], not [ <custom-ident> <integer>? ]#.)

The definition of <'font-family'> is [ <family-name> | <generic-family> ]#. When used in the context of <'font'> without the #-multiplier, this implies that only a single <family-name> or <generic-family> can be used as the <'font-family'> value. However, the <'font'> property allows a comma-separated list of family names, which necessitates the explicit inclusion of the #-multiplier with <'font-family'> in the <'font'> syntax.

Additionally, the brackets are redundant in the syntaxes for <font-variant-css2> and <font-width-css3>.

Note: I made changes only to font-4, as font-3 appears to be generated from an external source, and I couldn't locate the source.

@w3cbot
Copy link

w3cbot commented Sep 4, 2024

lahmatiy marked as non substantive for IPR from ash-nazg.

lahmatiy added a commit to csstree/csstree that referenced this pull request Sep 4, 2024
@svgeesus svgeesus merged commit 22558d5 into w3c:main Sep 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants