Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[css-text] Introduce a text-wrap-style value focused on orphans #10837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-text] Introduce a text-wrap-style value focused on orphans #10837
Changes from 2 commits
62c13c9
75b9d6f
6c5a465
7133ac8
f160c5d
f474aaa
255cd9e
cf869ac
b7317a1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc: @astearns The key is to find a term that indicates that the value is about getting rid of orphans, but not in all circumstances, and not at any cost.
avoid
as suggested here by @fantasai is already used in CSS (see https://drafts.csswg.org/indexes/) in a number of places with the meaning "don't, unless [X]", so I think it can work: the precise criteria for when not to do it is left up to the UA, but it is there.To me,
reduce
could work too, but the meaning is almost too weak: instead of a rule generally applied with exceptions as implied by avoid, it would seem to indicate a slant, a preference. It's not wholly inappropriate here, especially given that everything is largely up to the user agent anyway, but that seems weaker than the author intent we're aiming for.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m OK going with
avoid
for now. But I do think that authors are going to expect that all orphans will be eliminated, and UAs absolutely should not do that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If they don't think about too much, probably. But if you show them examples of cases where it would be bad to do so, and it doesn't do so, I suspect they'll be happy with the result, since forcibly doing it would be ugly.