Skip to content

[css-overflow-5] Editoral - move scroll buttons under scroll navigation controls #11222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

flackr
Copy link
Contributor

@flackr flackr commented Nov 15, 2024

No description provided.

@flackr flackr requested a review from tabatkins November 15, 2024 15:58
@flackr
Copy link
Contributor Author

flackr commented Nov 15, 2024

@tabatkins What do you think of grouping markers and buttons under the common scroll navigation controls section? I thought this might be useful for having a place to hang the focus order between them.

If you think it should be separate then I'll probably move scroll markers to be the top level section instead.

@tabatkins
Copy link
Member

Ah, I made this change myself when I was writing the focus order text. Weird that this isn't recording a conflict...

@tabatkins tabatkins closed this Nov 21, 2024
@flackr flackr deleted the scroll-buttons-navigation-controls branch November 22, 2024 16:05
@flackr
Copy link
Contributor Author

flackr commented Nov 22, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants