[css-color-hdr-1] use one-or-more for dynamic-range-limit-mix grammar production
#11349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorry, this was my mistake. I intended for commas to be required.
My inclination would be to allow single-argument issues in |
|
Uploaded a patch with WPT tests at: |
|
And uploaded a PR to update Is that the extent of the changes that are desired here? |
|
I think so. Is there any reason this PR won't suffice for the change? I can't see a difference between this one and #11351 |
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Dec 11, 2024
Add tests for the edge cases brought up in: w3c/csswg-drafts#11349 Change-Id: Ia387c339d8555068cb70899bff850f4005423f82
svgeesus
approved these changes
Dec 11, 2024
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jan 7, 2025
Add tests for the edge cases brought up in: w3c/csswg-drafts#11349 Change-Id: Ia387c339d8555068cb70899bff850f4005423f82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6087798 Reviewed-by: Keith Cirkel <chromium@keithcirkel.co.uk> Commit-Queue: ccameron chromium <ccameron@chromium.org> Cr-Commit-Position: refs/heads/main@{#1403188}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jan 7, 2025
Add tests for the edge cases brought up in: w3c/csswg-drafts#11349 Change-Id: Ia387c339d8555068cb70899bff850f4005423f82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6087798 Reviewed-by: Keith Cirkel <chromium@keithcirkel.co.uk> Commit-Queue: ccameron chromium <ccameron@chromium.org> Cr-Commit-Position: refs/heads/main@{#1403188}
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Jan 10, 2025
… a=testonly Automatic update from web-platform-tests dynamic-range-limit: Add more WPT tests Add tests for the edge cases brought up in: w3c/csswg-drafts#11349 Change-Id: Ia387c339d8555068cb70899bff850f4005423f82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6087798 Reviewed-by: Keith Cirkel <chromium@keithcirkel.co.uk> Commit-Queue: ccameron chromium <ccameron@chromium.org> Cr-Commit-Position: refs/heads/main@{#1403188} -- wpt-commits: d2d172058342f786290e219b18288f40dc773ba9 wpt-pr: 49639
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jan 10, 2025
… a=testonly Automatic update from web-platform-tests dynamic-range-limit: Add more WPT tests Add tests for the edge cases brought up in: w3c/csswg-drafts#11349 Change-Id: Ia387c339d8555068cb70899bff850f4005423f82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6087798 Reviewed-by: Keith Cirkel <chromium@keithcirkel.co.uk> Commit-Queue: ccameron chromium <ccameron@chromium.org> Cr-Commit-Position: refs/heads/main@{#1403188} -- wpt-commits: d2d172058342f786290e219b18288f40dc773ba9 wpt-pr: 49639
sadym-chromium
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jan 14, 2025
Add tests for the edge cases brought up in: w3c/csswg-drafts#11349 Change-Id: Ia387c339d8555068cb70899bff850f4005423f82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6087798 Reviewed-by: Keith Cirkel <chromium@keithcirkel.co.uk> Commit-Queue: ccameron chromium <ccameron@chromium.org> Cr-Commit-Position: refs/heads/main@{#1403188}
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Jan 16, 2025
… a=testonly Automatic update from web-platform-tests dynamic-range-limit: Add more WPT tests Add tests for the edge cases brought up in: w3c/csswg-drafts#11349 Change-Id: Ia387c339d8555068cb70899bff850f4005423f82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6087798 Reviewed-by: Keith Cirkel <chromiumkeithcirkel.co.uk> Commit-Queue: ccameron chromium <ccameronchromium.org> Cr-Commit-Position: refs/heads/main{#1403188} -- wpt-commits: d2d172058342f786290e219b18288f40dc773ba9 wpt-pr: 49639 UltraBlame original commit: 7c7d7cd0908d881fd0dd873abe1e28d0a3c4f087
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Jan 16, 2025
… a=testonly Automatic update from web-platform-tests dynamic-range-limit: Add more WPT tests Add tests for the edge cases brought up in: w3c/csswg-drafts#11349 Change-Id: Ia387c339d8555068cb70899bff850f4005423f82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6087798 Reviewed-by: Keith Cirkel <chromiumkeithcirkel.co.uk> Commit-Queue: ccameron chromium <ccameronchromium.org> Cr-Commit-Position: refs/heads/main{#1403188} -- wpt-commits: d2d172058342f786290e219b18288f40dc773ba9 wpt-pr: 49639 UltraBlame original commit: 7c7d7cd0908d881fd0dd873abe1e28d0a3c4f087
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Jan 16, 2025
… a=testonly Automatic update from web-platform-tests dynamic-range-limit: Add more WPT tests Add tests for the edge cases brought up in: w3c/csswg-drafts#11349 Change-Id: Ia387c339d8555068cb70899bff850f4005423f82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6087798 Reviewed-by: Keith Cirkel <chromiumkeithcirkel.co.uk> Commit-Queue: ccameron chromium <ccameronchromium.org> Cr-Commit-Position: refs/heads/main{#1403188} -- wpt-commits: d2d172058342f786290e219b18288f40dc773ba9 wpt-pr: 49639 UltraBlame original commit: 7c7d7cd0908d881fd0dd873abe1e28d0a3c4f087
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the parsing tests in WPT (https://github.com/web-platform-tests/wpt/blob/master/css/css-color-hdr/parsing.html) it seems as though commas are required for each set of ident && groups here, however the spec is using the
+sigil which allows for "one or more" but doesn't specify commas. I think what might be desired here is to use#which is "one or more comma separated". This would satisfy the requirement for commas.I think, in addition, we might want to specify something like
#{2,}- considering all examples in the parse tests expect two or more values, and the spec talks about summing all values, I am unsure if it is redundant or not to specify just one value (e.g.dynamic-range-limit-mix(high 10%)).This doesn't resolve the recursive affordances that the WPTs allude to, but baby steps 😆