Skip to content

Conversation

@noamr
Copy link
Collaborator

@noamr noamr commented Jan 9, 2025

This applies to arc/curve/smooth.

Also fixes a bug where the arc target point was using only coordinate-pair.

Resolution: #10666 (comment)

Closes #10666

This applies to arc/curve/smooth.

Also fixes a bug where the arc target point was using only
coordinate-pair.

Resolution: w3c#10666 (comment)

Closes w3c#10666
@noamr noamr requested review from smfr and tabatkins January 9, 2025 10:06
@smfr
Copy link
Contributor

smfr commented Jan 9, 2025

The && in the other segment types has to change too.

@noamr
Copy link
Collaborator Author

noamr commented Jan 9, 2025

The && in the other segment types has to change too.

Which ones? Only curve, smooth & arc have additional parameters.

Copy link
Contributor

@smfr smfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I confused this with #10666. Your change is fine for this issue.

@noamr noamr merged commit 233bbec into w3c:main Jan 9, 2025
1 check passed
@noamr noamr deleted the shape-order branch January 9, 2025 17:08
@noamr noamr restored the shape-order branch January 9, 2025 23:20
@noamr
Copy link
Collaborator Author

noamr commented Jan 9, 2025

Oh, I confused this with #10666. Your change is fine for this issue.

You actually weren't, I forgot to push one of the commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[css-shapes-2] Order of points and control points in shape()

2 participants