Skip to content

Conversation

@bramus
Copy link
Contributor

@bramus bramus commented Jan 28, 2025

This PR fixes the following two issues with the css-mixins-1 spec:

  • Build errors when building the spec, caused by rogue </pre> tags.
  • Add the opening paren after @function. I believe this was erroneously removed in fe94b66.

@bramus bramus requested review from andruud and tabatkins and removed request for andruud January 28, 2025 00:03
Copy link
Member

@andruud andruud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if the commit title explained what the fix is.

@bramus bramus changed the title [css-mixins-1] Fix mixins spec [css-mixins-1] Fix build error Jan 28, 2025
@bramus
Copy link
Contributor Author

bramus commented Jan 28, 2025

It would be nice if the commit title explained what the fix is.

Reverted the incorrect commit + adjusted the title of the PR.

@bramus bramus requested a review from andruud January 28, 2025 19:36
@tabatkins tabatkins merged commit d3f7935 into w3c:main Mar 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants