Skip to content

[css-mixins-1] Fix build error - #11585

Merged
tabatkins merged 3 commits into
w3c:mainfrom
bramus:fix-mixins-spec
Mar 10, 2025
Merged

[css-mixins-1] Fix build error#11585
tabatkins merged 3 commits into
w3c:mainfrom
bramus:fix-mixins-spec

Conversation

@bramus

@bramus bramus commented Jan 28, 2025

Copy link
Copy Markdown
Contributor

This PR fixes the following two issues with the css-mixins-1 spec:

  • Build errors when building the spec, caused by rogue </pre> tags.
  • Add the opening paren after @function. I believe this was erroneously removed in fe94b66.

@bramus
bramus requested review from andruud and tabatkins and removed request for andruud January 28, 2025 00:03

@andruud andruud left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if the commit title explained what the fix is.

Comment thread css-mixins-1/Overview.bs Outdated
@bramus bramus changed the title [css-mixins-1] Fix mixins spec [css-mixins-1] Fix build error Jan 28, 2025
@bramus

bramus commented Jan 28, 2025

Copy link
Copy Markdown
Contributor Author

It would be nice if the commit title explained what the fix is.

Reverted the incorrect commit + adjusted the title of the PR.

@bramus
bramus requested a review from andruud January 28, 2025 19:36
@tabatkins
tabatkins merged commit d3f7935 into w3c:main Mar 10, 2025
@bramus
bramus deleted the fix-mixins-spec branch June 18, 2026 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants