[css-color-5] Simplify contrast-color(), per WG resolution. #11534 #11654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webkit-commit-queue
pushed a commit
to weinig/WebKit
that referenced
this pull request
Feb 11, 2025
https://bugs.webkit.org/show_bug.cgi?id=287410 Reviewed by Tim Nguyen. Updates the implementation of `contrast-color()` to match the latest spec which removed `max` parameter (see w3c/csswg-drafts#11654). Also updates tests and moves the non-WPT tests to WPT, changing the computed style tests to allow either `white` or `black` for all computed values due to the lack of agreed upon algorithm. To keep coverage of the algorithm in WebKit, a copy of the computed style test was kept in css/fast that retains the specific results. * LayoutTests/fast/css/color-computed-contrast-color-function-expected.txt: * LayoutTests/fast/css/color-computed-contrast-color-function.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-contrast-color-function-expected.txt: Copied from LayoutTests/fast/css/color-computed-contrast-color-function-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-contrast-color-function.html: Copied from LayoutTests/fast/css/color-computed-contrast-color-function.html. * LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-invalid-contrast-color-function-expected.txt: Renamed from LayoutTests/fast/css/color-invalid-contrast-color-function-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-invalid-contrast-color-function.html: Renamed from LayoutTests/fast/css/color-invalid-contrast-color-function.html. * LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-contrast-color-function-expected.txt: Renamed LayoutTests/fast/css/color-valid-contrast-color-function-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-contrast-color-function.html: Renamed LayoutTests/fast/css/color-valid-contrast-color-function.html. * Source/WebCore/css/parser/CSSPropertyParserConsumer+Color.cpp: * Source/WebCore/css/values/color/CSSContrastColor.cpp: * Source/WebCore/css/values/color/CSSContrastColor.h: * Source/WebCore/css/values/color/CSSContrastColorResolver.h: * Source/WebCore/css/values/color/CSSContrastColorSerialization.h: * Source/WebCore/style/values/color/StyleContrastColor.cpp: * Source/WebCore/style/values/color/StyleContrastColor.h: Canonical link: https://commits.webkit.org/290210@main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the f2f we agreed to drop the
maxargument and just always resolve to white/black for now, with the intention of resolving on additional functionality in the near future. (We just ran out of timebox for the topic.)