Skip to content

[css-gaps-1] Fixes for gap intersection point definition and pairing algorithm. #11720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 21, 2025

Conversation

kbabbitt
Copy link
Collaborator

  • Revert commit f8b28b2.
  • Update illustration for gap intersection points with spanning items in grid.
  • Fix "determine pairs of gap intersection points" algorithm to apply gap-rule-break as intended.
  • Minor markup enhancements.

@kbabbitt kbabbitt self-assigned this Feb 14, 2025
@kbabbitt
Copy link
Collaborator Author

Formatted preview here: https://kbabbitt.github.io/css-gap-decorations/pr-11720/Overview.html

@oSamDavis I can't add you as a "Reviewer" for some reason but could you ptal?

@@ -190,9 +183,8 @@ Breaking gap decorations into segments: The 'column-rule-break', 'row-rule-break
</dd>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it'll be helpful to add which intersection points are considered for -rule-break: intersection. So maybe along the lines of "Gap decorations start and end at every valid gap intersection point. A valid gap intersection point intersection is defined as one that forms a visible cross or T intersection." then maybe a "refer to the steps below."

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree that the value definitions need to be updated, but I'd prefer not to introduce another new term ("valid") if we can avoid it. I changed the value definitions to be based around visible intersections and added a link to the algorithm steps for precise details. I also reordered the value definitions here to match the order they appear in the algorithm. Let me know what you think.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just took a look and it looks great!

@kbabbitt kbabbitt requested a review from oSamDavis February 20, 2025 19:16
Copy link

@oSamDavis oSamDavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New edits look good to me. Thanks!

@kbabbitt kbabbitt merged commit 930c679 into w3c:main Feb 21, 2025
1 check passed
@kbabbitt kbabbitt deleted the gaps-revise-rule-break branch February 21, 2025 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants