[css-pseudo] only propagate ::first-line to ancestors in BFC #1174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This text was copied from CSS2.1, but nowadays there are block containers which do not participate in a BFC other than table-cell and inline-block, e.g. flex items and grid items.
Contributor
Author
|
Maybe table captions should also be excluded (#1192). |
Contributor
Author
|
An alternative wording would be
|
Collaborator
|
I think this is mostly correct, but it's not clear what happens with multicol. Partly this is because in the past multicol was considered a special type of block container, and right now it's not entirely clear--so we should call it out explicitly. |
Collaborator
|
@Loirooriol Wasn't able to easily resolve the conflicts, so I just generated a new fix. Basically the same wording, except I also added a parenthetical to handle table captions. Gonna close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current text was copied from CSS2.1, but nowadays there are block containers which do not participate in a BFC other than table-cell and inline-block, e.g. flex items and grid items.
This is a minor fix, I think the whole algorithm should be replaced with something like #1158.