Skip to content

[css-images-4] Add the use of “longer” hue interpolation for the color wheel in the example #11755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion css-images-4/Overview.bs
Original file line number Diff line number Diff line change
Expand Up @@ -1701,7 +1701,17 @@ Conic Gradient Examples</h4>
width: 200px; height: 200px;
</pre>

<img src="images/conic5.png" alt="" >
You can also achieve the same effect using "longer" hue interpolation. This is more concise and makes it easy to switch to other color spaces.

<pre class=lang-css>
background: radial-gradient(closest-side, gray, transparent),
conic-gradient(in hsl longer hue, red 0 100%);
transform: scaleX(-1);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is weird, we should just flip the image instead and go with a standard rainbow.

Copy link
Contributor Author

@yisibl yisibl Feb 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of color pickers that use a counterclockwise rainbow, can we consider adding a related keyword to the gradient to change the direction of rotation?(I can file a new issue.)

That way we no longer need scaleX(-1).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can always just reverse your color stops. That won't work for this particular rainbow example (you'll have to add some additional stops instead), but that's fine; using longer hue specifically to generate rainbows is something that's neat but not intentionally supported as a feature.

border-radius: 50%;
width: 200px; height: 200px;
</pre>

<img src="images/conic5.png" alt="color wheel">
Copy link
Contributor Author

@yisibl yisibl Feb 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some differences between the current image (left) and the CSS rendering(Chrome 133), should we update the image?

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we should.

The rendering in Firefox (on Win, at least) also shows a rendering bug, but that is a separate issue

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@svgeesus You wrote:

The rendering in Firefox (on Win, at least) also shows a rendering bug, but that is a separate issue

It looks OK to me on my Windows machine. Could you clarify what rendering bug you're seeing, please? (Or file a bug at https://bugzilla.mozilla.org with details.) Thanks!

Copy link
Contributor Author

@yisibl yisibl Feb 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we should.

@svgeesus Okay, I'll modify it.

Copy link
Contributor

@svgeesus svgeesus Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks OK to me on my Windows machine. Could you clarify what rendering bug you're seeing, please?

gradient-bug

https://codepen.io/svgeesus/pen/KwKzgQE

Nightly 137.0a1 (2025-02-26) (64-bit) Windows 11

Bug filed: https://bugzilla.mozilla.org/show_bug.cgi?id=1951113

</div>

<div class='example' id='ex-conic-pie'>
Expand Down