Skip to content

Conversation

@flackr
Copy link
Contributor

@flackr flackr commented Feb 20, 2025

The @viewport rule was removed[1] in favor of using viewport meta properties. This updates viewport-fit to follow this change.

[1] https://www.w3.org/TR/css-viewport-1/#since-the-29-march-2016-working-draft

…a element.

The @Viewport rule was removed in favor of using viewport meta properties.
This updates viewport-fit to follow this change.
@flackr flackr requested a review from tabatkins February 20, 2025 18:19
'viewport-fit' can control the clipped area by setting the size of the visual viewport.
'viewport-fit' can control the clipped area by setting the size of the layout viewport.

Values have the following meanings:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In our implementation there seems to be no difference between auto and contain, it may make sense to just remove the auto value and specify the default behavior is contain, though I tried to keep this PR to a strictly editorial update of following the change in the css-viewport spec.

@flackr
Copy link
Contributor Author

flackr commented Feb 27, 2025

@tabatkins can you take a look? This is updating the spec to match the way browsers are implementing viewport-fit - on the meta element.

Copy link
Member

@tabatkins tabatkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tabatkins tabatkins merged commit 460750b into w3c:main Mar 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants