[web-animations-1] Make commitStyles use an endpoint-inclusive active interval - #11881
Merged
Conversation
Contributor
Author
|
Leaving this as a draft until we've determined that this change is Web-compatible. |
Contributor
Author
|
Putting this up for review since the use counter data we've collected in Firefox suggests this change is safe to make. There are WPT for this here and once this PR is merged, we'll rename |
Contributor
Author
flackr
approved these changes
Jun 19, 2025
flackr
left a comment
Contributor
There was a problem hiding this comment.
This looks good, thanks! Sorry I didn't see this earlier. The examples are so much cleaner, I'm glad it looked reasonably safe :-).
Contributor
Author
|
Thank you! |
philwo
pushed a commit
to philwo/chromium
that referenced
this pull request
Oct 30, 2025
This patch aligns commitStyles() behavior with a recent spec update. The WPTs have been already updated and that's causing new failures in Chromium. This patch fixes our implementation to pass these tests and to align with the spec. Spec: w3c/csswg-drafts#11881 Bug: 40715046 Change-Id: I57a24bb29bd350ef66778c1259a2bde3fa19c769 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6904038 Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/main@{#1538000}
jmajnert
pushed a commit
to jmajnert/chromium
that referenced
this pull request
Nov 6, 2025
This patch aligns commitStyles() behavior with a recent spec update. The WPTs have been already updated and that's causing new failures in Chromium. This patch fixes our implementation to pass these tests and to align with the spec. Spec: w3c/csswg-drafts#11881 Bug: 40715046 Change-Id: I57a24bb29bd350ef66778c1259a2bde3fa19c769 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6904038 Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/main@{#1538000}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5394.