Skip to content

[css-sizing-4] contain-intrinsic-* properties should not allow negative lengths. See #11945 #11959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2025
Merged

[css-sizing-4] contain-intrinsic-* properties should not allow negative lengths. See #11945 #11959

merged 1 commit into from
Mar 18, 2025

Conversation

weinig
Copy link
Contributor

@weinig weinig commented Mar 18, 2025

No description provided.

Loirooriol
Loirooriol approved these changes Mar 18, 2025
View reviewed changes
Copy link
Contributor

@Loirooriol Loirooriol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I think this needs editor approval since it has behavior implications.

@tabatkins
Copy link
Member

since it has behavior implications.

Only theoretically; I expect in practice impls were clamping it by 0 anyway. This looks like an easy bugfix to me.

@tabatkins tabatkins merged commit cd275c6 into w3c:main Mar 18, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Loirooriol Loirooriol Loirooriol approved these changes

@jensimmons jensimmons Awaiting requested review from jensimmons

@tabatkins tabatkins Awaiting requested review from tabatkins

@fantasai fantasai Awaiting requested review from fantasai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weinig @tabatkins @Loirooriol