Skip to content

[css-gaps-1] Use commas instead of slashes for *-rule shorthands. #11496 #12051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 12, 2025

Conversation

kbabbitt
Copy link
Collaborator

@kbabbitt kbabbitt commented Apr 4, 2025

No description provided.

@kbabbitt kbabbitt requested a review from tabatkins April 4, 2025 15:04
@kbabbitt kbabbitt self-assigned this Apr 4, 2025
@kbabbitt
Copy link
Collaborator Author

kbabbitt commented Apr 4, 2025

@tabatkins I think you mentioned during the discussion that you had a grammar nit to raise?

@tabatkins
Copy link
Member

GitHub UI is busted for multi-line suggestions (constantly complains that I'm "adding suggestions to deleted lines"), but here you go:

		<dfn>&lt;gap-rule-list&gt;</dfn>        = <<gap-rule-or-repeat>>#
		<dfn>&lt;gap-auto-rule-list&gt;</dfn>   = <<gap-rule-or-repeat>>#? , 
								             <<gap-auto-repeat-rule>> , 
								             <<gap-rule-or-repeat>>#?
		<dfn>&lt;gap-rule-or-repeat&gt;</dfn>   = <<gap-rule>> | <<gap-repeat-rule>>
		<dfn>&lt;gap-repeat-rule&gt;</dfn>      = repeat( <<integer [1,∞]>> , <<gap-rule>># )
		<dfn>&lt;gap-auto-repeat-rule&gt;</dfn> = repeat( auto , <<gap-rule>># )
		<dfn>&lt;gap-rule&gt;</dfn>             = <<line-width>> || <<line-style>> || <<color>>
  • <gap-auto-rule-list> needed commas between the terms. (They're implicitly omitted if the <gap-rule-or-repeat> is omitted.)
  • Removed all the unnecessary brackets. (This was just a nit, but having brackets does suggest you need brackets, and it's a little confusing when that's not true.)

@kbabbitt kbabbitt merged commit f88344e into w3c:main Apr 12, 2025
1 check passed
@kbabbitt
Copy link
Collaborator Author

Thanks @tabatkins, I incorporated your suggestions and merged.

@kbabbitt kbabbitt deleted the gaps-shorthand-grammar branch April 12, 2025 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants