[css-viewport-1] Make sure to always return one segment#12088
Merged
Conversation
Contributor
Author
|
cc @bramus |
Contributor
|
This makes sense to me. |
jakearchibald
approved these changes
Apr 16, 2025
bramus
approved these changes
Apr 16, 2025
Contributor
|
Thanks! Before merging the change I think we do need a resolution on the issue for this, which can be done async. |
tabatkins
requested changes
Apr 16, 2025
Member
tabatkins
left a comment
There was a problem hiding this comment.
Needs to say that it still returns an array, containing that single size.
When the device is not folded (flat) or it's a regular device always return one segment (typically the size of the viewport). This is to follow developer feedback and consistency with the rest of the platform.
Contributor
Author
|
@tabatkins updated the wording, good catch. Thanks. |
Contributor
Author
|
The resolution was approved so @tabatkins or @emilio please merge at your earliest convenience. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the device is not folded (flat) or it's a regular device always return one segment (typically the size of the viewport). This is to follow developer feedback and consistency with the rest of the platform.
#11957