[cssom-1] Correct typos and grammar in "serialize a CSS declaration block" #12187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtkinsSJ
commented
May 13, 2025
| @@ -2353,20 +2353,20 @@ To <dfn export>serialize a CSS declaration block</dfn> <var>declaration block</v | |||
| <li><i>Shorthand loop</i>: For each <var>shorthand</var> in <var>shorthands</var>, follow these substeps: | |||
| <ol> | |||
| <li>Let <var>longhands</var> be an array consisting of all <a>CSS declarations</a> in <var>declaration block</var>'s | |||
| <a for="CSSStyleDeclaration">declarations</a> that that are not in <var>already serialized</var> and have a | |||
| <a for="CSSStyleDeclaration">declarations</a> that are not in <var>already serialized</var> and have a | |||
| <a for="CSS declaration">property name</a> that | |||
| maps to one of the shorthand properties in <var>shorthands</var>. | |||
There was a problem hiding this comment.
Should this be "that maps to shorthand"? The loop is only concerned about that, not the entire list of possible shorthands.
There was a problem hiding this comment.
I've pushed a commit to correct this.
There was a problem hiding this comment.
Actually I've undone that commit. I don't understand why we have both longhands and current longhands. longhands only gets used to then copy into current longhands. Maybe it's supposed to only be created once instead of each time in shorthand loop?
3aba8fb to
c16e9fe
Compare
AtkinsSJ
added a commit
to AtkinsSJ/ladybird
that referenced
this pull request
May 13, 2025
Oh boy this is confusing. w3c/csswg-drafts#12187
|
@emilio for review |
|
svgeesus marked as non substantive for IPR from ash-nazg. |
emilio
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the "that that" mistake while implementing this, then identified a couple of other small corrections. Not all of these are "wrong" exactly, they're just not worded the way the specs usually do.