Skip to content

[css-flexbox] Fix animation type of 'flex-basis' #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2016

Conversation

birtles
Copy link
Contributor

@birtles birtles commented May 18, 2016

'width' is not an animation type and quoting width like this links to the width property.

'width' is not an animation type and quoting width like this links to
the width property.
@birtles
Copy link
Contributor Author

birtles commented May 19, 2016

@tabatkins Can you please take a look? Thanks

@tabatkins tabatkins merged commit 7da8ff2 into master May 19, 2016
@tabatkins tabatkins deleted the birtles/fix-flex-basis-animation-type branch May 19, 2016 23:28
@fantasai
Copy link
Collaborator

This is actually not a correct fix, because it doesn't handle keywords. The link to the 'width' property was intentional, as it should animate exactly the same as 'width'. Switched it to 'discrete or keywords, otherwise as length, percentage, or calc'.

@birtles
Copy link
Contributor Author

birtles commented May 20, 2016

Yeah, the intention (as mentioned in the commit for #114) is to update CSS transitions to make it more obvious that if you can't stuff something into the specified animation type, you fall back to discrete. Otherwise we'll be typing this everywhere. This is fine for now though.

@syncbot syncbot restored the birtles/fix-flex-basis-animation-type branch May 21, 2016 20:07
@birtles birtles deleted the birtles/fix-flex-basis-animation-type branch May 31, 2016 01:23
@syncbot syncbot restored the birtles/fix-flex-basis-animation-type branch May 31, 2016 22:23
@birtles birtles deleted the birtles/fix-flex-basis-animation-type branch July 25, 2016 00:54
@syncbot syncbot restored the birtles/fix-flex-basis-animation-type branch August 1, 2016 01:56
@plinss plinss deleted the birtles/fix-flex-basis-animation-type branch August 2, 2017 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants