[css-borders-4] Improve definition of superellipse() #12263
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I'm in the middle of an editorial rewrite of this section that also addresses these issues, so I'll close this just to avoid causing more clashes than necessary. Sorry about that. ^_^ |
Collaborator
Author
|
Dont' worry. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
superellipse()is currently used in<corner-shape-value>with an inline value definition that does not link to its definition. Besides, this value definition uses<number [-∞,∞]>, which is just<number>.This definition also includes its parameters, which are different than in
<corner-shape-value>. Its syntax is not properly defined in a production rule.This PR fixes all these problems.