-
Notifications
You must be signed in to change notification settings - Fork 757
[cssom-view-1] Scroll methods in Element and Window return Promises #12355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+65
−39
Merged
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
4562258
[cssom-view-1] Scroll methods in Element and Window return Promises
mustaqahmed 0442bca
WIP:perform-a-scroll
mustaqahmed 4fd84a2
WIP:viewport-perform-a-scroll
mustaqahmed 8ffa952
WIP:all-except-scrollintoview
mustaqahmed 66cab71
Done.
mustaqahmed b579a1b
Add issue ref.
mustaqahmed 0e0c503
typo
mustaqahmed 36c0b23
promise return tweaks
mustaqahmed 14d53b2
Tweak to scroll abort
mustaqahmed 806f432
Return promises before running remaining steps in parallel.
mustaqahmed 8a821f2
Fix issue ref
mustaqahmed 3145e67
Switch to Promise<undefined>
mustaqahmed 8a3a502
Don't interrupt all scrollers.
mustaqahmed 340f7f8
s/have been resolved/have settled/
mustaqahmed f015eaf
Fix scrollend firing.
mustaqahmed cfe0991
Add links to Promise def
mustaqahmed 9490f04
Merge branch 'main' into main
mustaqahmed File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add issue ref.
- Loading branch information
commit b579a1bb1b0f264df91839941ad3357dd13c33df
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.