[css-ui-4] define appearance: base-select #12402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was resolved here: w3c#10440 (comment) Base appearance for the select element and its picker is going to be published in the HTML spec very soon.
dbaron
reviewed
Jun 26, 2025
css-ui-4/Overview.bs
Outdated
| <dt><dfn>base-select</dfn> | ||
| <dd> | ||
| The effect of ''appearance/base-select'' depends on the element it is applied to: | ||
| <dl class=switch> |
Member
There was a problem hiding this comment.
I'd suggest two changes here:
- first, switch the order of the two items in this list so that the second one can just be "Everything else" (and you don't have to repeat "other than the
<select>element" in the definition either). - second, for the
<select>/::picker(select)case, I think it's better to fully defer to the definition ofappearance/base(as you do for the other half) rather than trying to repeat it.
Contributor
Author
There was a problem hiding this comment.
Done and done, thanks!
dbaron
reviewed
Jun 26, 2025
Member
dbaron
left a comment
There was a problem hiding this comment.
Looks good now, though I think it would be good if you could also fix the indentation so it matches the surroundings (which I think likely uses tabs -- if so you should also use tabs).
dbaron
approved these changes
Jun 26, 2025
Member
dbaron
left a comment
There was a problem hiding this comment.
(I thought I hit the "Approve" radio button last time... but see above comment.)
Contributor
Author
Done, thanks! |
dbaron
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was resolved here:
#10440 (comment)
Base appearance for the select element and its picker is going to be published in the HTML spec very soon.