[css-conditional-5] Use the generic <boolean-expr>#12640
Open
cdoublev wants to merge 1 commit into
Open
Conversation
AtkinsSJ
reviewed
Aug 22, 2025
508e3e8 to
b0f10f9
Compare
fantasai
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a consequence of 5f19369,
<boolean-condition>is extracted byw3c/reffyand exposed tow3c/webrefusers.However,
<boolean-condition>was intended to be defined generically, as noted under its definition, and this has been done with<boolean-expr>in 4fd47d8 in CSS Values 5.Therefore this PR replaces
<boolean-condition>with<boolean-expr[ <if-test> ]>in the prelude of@whenand@else. The leaves of the boolean condition/expresion are consequently different:I assume these differences should not exist and will be fixed later if required, and that accepting
style()queries is ok.