Skip to content

Conversation

@xfq
Copy link
Member

@xfq xfq commented Apr 21, 2017

  • Fix reference to CSS21
  • Change introduction section to <h2>

@xfq xfq changed the title [css-logical-props] Editorial fixes [css-logical] Editorial fixes May 7, 2017
@xfq
Copy link
Member Author

xfq commented May 7, 2017

BTW, commit 2da592b made the "GitHub Issues" entry of the spec header link to css-logical-1 Current Work , so the GitHub label also needs adjustment.

/cc @fantasai

@gsnedders gsnedders added the css-logical-1 Current Work label May 25, 2017
@gsnedders gsnedders requested review from atanassov and fantasai May 25, 2017 09:49
Copy link
Collaborator

@frivoal frivoal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not the editor, but the changes are generic enough I feel comfortable reviewing them anyway. Looks good to me.

@frivoal
Copy link
Collaborator

frivoal commented Jun 6, 2017

@xfq could you rebase to the latest master? The path to this file has changed (from css-logical-props/Overview.bs to css-logical/Overview.bs), making this PR impossible to merge as is.

@xfq
Copy link
Member Author

xfq commented Jun 6, 2017

@frivoal Thanks for the review! Since I don't know how to rebase this branch while detecting renames, I'll create a new PR.

@xfq xfq closed this Jun 6, 2017
@xfq
Copy link
Member Author

xfq commented Jun 6, 2017

See #1503.

@xfq xfq deleted the logical-props branch June 6, 2017 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

css-logical-1 Current Work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants