[css-view-transition-2] Simplify handling of ::view-transition#12767
Open
Psychpsyo wants to merge 1 commit into
Open
[css-view-transition-2] Simplify handling of ::view-transition#12767Psychpsyo wants to merge 1 commit into
Psychpsyo wants to merge 1 commit into
Conversation
828c146 to
d03b676
Compare
Collaborator
|
css-view-transitions-1 was merged into css-view-transitions-1 and is now frozen. Mind making the patch work there? |
d03b676 to
d05b7a7
Compare
Contributor
Author
|
This is now for view-transitions-2 and also fixes the bit where element-scoped transitions were using the global 'show view transition tree' boolean (by virtue of it not existing anymore). |
d05b7a7 to
ddedf72
Compare
Contributor
Author
|
Sometime since then, this had a merge conflict, but I've also resolved that now. |
Collaborator
|
Deferring this to @vmpstr |
Contributor
Author
|
@vmpstr It's been over a month. Any input on this? |
vmpstr
approved these changes
Apr 8, 2026
Member
vmpstr
left a comment
There was a problem hiding this comment.
Sorry for the delay. Looks good with a nit
This also makes element-scoped view-transitions not use the global 'show view transition tree' boolean anymore.
ddedf72 to
a8bdf77
Compare
Contributor
Contributor
Author
I've created and linked a W3C account now. Edit: I've also now handed in an application to become an invited expert. (I think this is required?) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my writeup of the changes I suggested in #12760. I'm filing this so that there are actual, concrete changes that can be discussed instead of the vague-ish description I gave in that issue.
I'd be happy to sign the IPR thingy if this gets approved.