-
Notifications
You must be signed in to change notification settings - Fork 757
Rename direction to scrolled, updated explainer #12881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tabatkins
approved these changes
Sep 30, 2025
tidoust
added a commit
to tidoust/csswg-drafts
that referenced
this pull request
Oct 2, 2025
The `direction` feature was renamed to `scrolled` in w3c#12881, but feature values were still referencing `direction`.
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 3, 2025
Resolved in: w3c/csswg-drafts#12623 (comment) Changes are already merged: w3c/csswg-drafts#12881 Bug: 414556050 Change-Id: I5aaf79856da2823a937cc7565489b8db09c0876c
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Oct 3, 2025
Resolved in: w3c/csswg-drafts#12623 (comment) Changes are already merged: w3c/csswg-drafts#12881 Bug: 414556050 Change-Id: I5aaf79856da2823a937cc7565489b8db09c0876c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7004323 Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: Munira Tursunova <moonira@google.com> Cr-Commit-Position: refs/heads/main@{#1524862}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 3, 2025
Resolved in: w3c/csswg-drafts#12623 (comment) Changes are already merged: w3c/csswg-drafts#12881 Bug: 414556050 Change-Id: I5aaf79856da2823a937cc7565489b8db09c0876c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7004323 Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: Munira Tursunova <moonira@google.com> Cr-Commit-Position: refs/heads/main@{#1524862}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 3, 2025
Resolved in: w3c/csswg-drafts#12623 (comment) Changes are already merged: w3c/csswg-drafts#12881 Bug: 414556050 Change-Id: I5aaf79856da2823a937cc7565489b8db09c0876c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7004323 Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: Munira Tursunova <moonira@google.com> Cr-Commit-Position: refs/heads/main@{#1524862}
lando-prod-mozilla bot
pushed a commit
to mozilla-firefox/firefox
that referenced
this pull request
Oct 14, 2025
…l-state(scrolled:), a=testonly Automatic update from web-platform-tests Rename scroll-state(direction:) to scroll-state(scrolled:) Resolved in: w3c/csswg-drafts#12623 (comment) Changes are already merged: w3c/csswg-drafts#12881 Bug: 414556050 Change-Id: I5aaf79856da2823a937cc7565489b8db09c0876c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7004323 Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: Munira Tursunova <moonira@google.com> Cr-Commit-Position: refs/heads/main@{#1524862} -- wpt-commits: d825b643a2e3342adc58b0170e9351a37cf4555a wpt-pr: 55233
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 16, 2025
…l-state(scrolled:), a=testonly Automatic update from web-platform-tests Rename scroll-state(direction:) to scroll-state(scrolled:) Resolved in: w3c/csswg-drafts#12623 (comment) Changes are already merged: w3c/csswg-drafts#12881 Bug: 414556050 Change-Id: I5aaf79856da2823a937cc7565489b8db09c0876c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7004323 Reviewed-by: Robert Flack <flackrchromium.org> Commit-Queue: Munira Tursunova <mooniragoogle.com> Cr-Commit-Position: refs/heads/main{#1524862} -- wpt-commits: d825b643a2e3342adc58b0170e9351a37cf4555a wpt-pr: 55233 UltraBlame original commit: afc5b9ada9cab42ef940ce7ba316b2eb422ab0c0
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 16, 2025
…l-state(scrolled:), a=testonly Automatic update from web-platform-tests Rename scroll-state(direction:) to scroll-state(scrolled:) Resolved in: w3c/csswg-drafts#12623 (comment) Changes are already merged: w3c/csswg-drafts#12881 Bug: 414556050 Change-Id: I5aaf79856da2823a937cc7565489b8db09c0876c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7004323 Reviewed-by: Robert Flack <flackrchromium.org> Commit-Queue: Munira Tursunova <mooniragoogle.com> Cr-Commit-Position: refs/heads/main{#1524862} -- wpt-commits: d825b643a2e3342adc58b0170e9351a37cf4555a wpt-pr: 55233 UltraBlame original commit: afc5b9ada9cab42ef940ce7ba316b2eb422ab0c0
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 16, 2025
…l-state(scrolled:), a=testonly Automatic update from web-platform-tests Rename scroll-state(direction:) to scroll-state(scrolled:) Resolved in: w3c/csswg-drafts#12623 (comment) Changes are already merged: w3c/csswg-drafts#12881 Bug: 414556050 Change-Id: I5aaf79856da2823a937cc7565489b8db09c0876c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7004323 Reviewed-by: Robert Flack <flackrchromium.org> Commit-Queue: Munira Tursunova <mooniragoogle.com> Cr-Commit-Position: refs/heads/main{#1524862} -- wpt-commits: d825b643a2e3342adc58b0170e9351a37cf4555a wpt-pr: 55233 UltraBlame original commit: afc5b9ada9cab42ef940ce7ba316b2eb422ab0c0
mertcanaltin
pushed a commit
to mertcanaltin/wpt
that referenced
this pull request
Oct 26, 2025
Resolved in: w3c/csswg-drafts#12623 (comment) Changes are already merged: w3c/csswg-drafts#12881 Bug: 414556050 Change-Id: I5aaf79856da2823a937cc7565489b8db09c0876c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7004323 Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: Munira Tursunova <moonira@google.com> Cr-Commit-Position: refs/heads/main@{#1524862}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename scroll-state
directionfeature toscrolled, as resolved in #12623 (comment).Updated scroll-state explainer with the new name for direction, specified it is only changed by relative scrolls and added semantic line breaks in the
scrolledsection.