-
Notifications
You must be signed in to change notification settings - Fork 757
[css-background-3] Adjust border-radius outset correction #12896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new adjustment makes the radius reduction factor in the minimum radius percentage of the corner, making it less pronounced the closer the corner's border-radius gets to 50%. Closes w3c#7103 Resolution: w3c#7103 (comment)
Loirooriol
reviewed
Oct 4, 2025
|
Review anyone? @tabatkins ? |
tabatkins
reviewed
Oct 16, 2025
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 16, 2025
Use the new coverage-based algorithm that takes into account the percentage of the radius from the overall width/height. Also rename OutsetForMarginOrShadow to OutsetWithCornerCorrection, as it better describes what it does. See w3c/csswg-drafts#12896 Bug: 448651073 Change-Id: I1eaca184c94bf9ad5b7c37a2091eb1f428406efc
tabatkins
approved these changes
Oct 16, 2025
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Oct 16, 2025
Use the new coverage-based algorithm that takes into account the percentage of the radius from the overall width/height. Also rename OutsetForMarginOrShadow to OutsetWithCornerCorrection, as it better describes what it does. See w3c/csswg-drafts#12896 Bug: 448651073 Change-Id: I1eaca184c94bf9ad5b7c37a2091eb1f428406efc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7013748 Reviewed-by: Kyle Charbonneau <kylechar@chromium.org> Commit-Queue: Noam Rosenthal <nrosenthal@google.com> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1531048}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 16, 2025
Use the new coverage-based algorithm that takes into account the percentage of the radius from the overall width/height. Also rename OutsetForMarginOrShadow to OutsetWithCornerCorrection, as it better describes what it does. See w3c/csswg-drafts#12896 Bug: 448651073 Change-Id: I1eaca184c94bf9ad5b7c37a2091eb1f428406efc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7013748 Reviewed-by: Kyle Charbonneau <kylechar@chromium.org> Commit-Queue: Noam Rosenthal <nrosenthal@google.com> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1531048}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 16, 2025
Use the new coverage-based algorithm that takes into account the percentage of the radius from the overall width/height. Also rename OutsetForMarginOrShadow to OutsetWithCornerCorrection, as it better describes what it does. See w3c/csswg-drafts#12896 Bug: 448651073 Change-Id: I1eaca184c94bf9ad5b7c37a2091eb1f428406efc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7013748 Reviewed-by: Kyle Charbonneau <kylechar@chromium.org> Commit-Queue: Noam Rosenthal <nrosenthal@google.com> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1531048}
jrguzman-ms
pushed a commit
to msft-mirror-aosp/platform.external.libchrome
that referenced
this pull request
Oct 22, 2025
Use the new coverage-based algorithm that takes into account the percentage of the radius from the overall width/height. Also rename OutsetForMarginOrShadow to OutsetWithCornerCorrection, as it better describes what it does. See w3c/csswg-drafts#12896 Bug: 448651073 Change-Id: I1eaca184c94bf9ad5b7c37a2091eb1f428406efc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7013748 Reviewed-by: Kyle Charbonneau <kylechar@chromium.org> Commit-Queue: Noam Rosenthal <nrosenthal@google.com> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1531048} CrOS-Libchrome-Original-Commit: fd139d5d7350a66492181c3291784fb29c6b74d9
lando-prod-mozilla bot
pushed a commit
to mozilla-firefox/firefox
that referenced
this pull request
Oct 24, 2025
…estonly Automatic update from web-platform-tests Apply new border-radius/spread algo Use the new coverage-based algorithm that takes into account the percentage of the radius from the overall width/height. Also rename OutsetForMarginOrShadow to OutsetWithCornerCorrection, as it better describes what it does. See w3c/csswg-drafts#12896 Bug: 448651073 Change-Id: I1eaca184c94bf9ad5b7c37a2091eb1f428406efc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7013748 Reviewed-by: Kyle Charbonneau <kylechar@chromium.org> Commit-Queue: Noam Rosenthal <nrosenthal@google.com> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1531048} -- wpt-commits: cc6a94ac8793499299b00dde8b97c41aa5c95216 wpt-pr: 55490
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Oct 25, 2025
…estonly Automatic update from web-platform-tests Apply new border-radius/spread algo Use the new coverage-based algorithm that takes into account the percentage of the radius from the overall width/height. Also rename OutsetForMarginOrShadow to OutsetWithCornerCorrection, as it better describes what it does. See w3c/csswg-drafts#12896 Bug: 448651073 Change-Id: I1eaca184c94bf9ad5b7c37a2091eb1f428406efc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7013748 Reviewed-by: Kyle Charbonneau <kylechar@chromium.org> Commit-Queue: Noam Rosenthal <nrosenthal@google.com> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1531048} -- wpt-commits: cc6a94ac8793499299b00dde8b97c41aa5c95216 wpt-pr: 55490
mertcanaltin
pushed a commit
to mertcanaltin/wpt
that referenced
this pull request
Oct 26, 2025
Use the new coverage-based algorithm that takes into account the percentage of the radius from the overall width/height. Also rename OutsetForMarginOrShadow to OutsetWithCornerCorrection, as it better describes what it does. See w3c/csswg-drafts#12896 Bug: 448651073 Change-Id: I1eaca184c94bf9ad5b7c37a2091eb1f428406efc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7013748 Reviewed-by: Kyle Charbonneau <kylechar@chromium.org> Commit-Queue: Noam Rosenthal <nrosenthal@google.com> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1531048}
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 29, 2025
…estonly Automatic update from web-platform-tests Apply new border-radius/spread algo Use the new coverage-based algorithm that takes into account the percentage of the radius from the overall width/height. Also rename OutsetForMarginOrShadow to OutsetWithCornerCorrection, as it better describes what it does. See w3c/csswg-drafts#12896 Bug: 448651073 Change-Id: I1eaca184c94bf9ad5b7c37a2091eb1f428406efc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7013748 Reviewed-by: Kyle Charbonneau <kylecharchromium.org> Commit-Queue: Noam Rosenthal <nrosenthalgoogle.com> Reviewed-by: Philip Rogers <pdrchromium.org> Cr-Commit-Position: refs/heads/main{#1531048} -- wpt-commits: cc6a94ac8793499299b00dde8b97c41aa5c95216 wpt-pr: 55490 UltraBlame original commit: f8971006e2aa005cd335199615bb9b1c9c03e5f5
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 29, 2025
…estonly Automatic update from web-platform-tests Apply new border-radius/spread algo Use the new coverage-based algorithm that takes into account the percentage of the radius from the overall width/height. Also rename OutsetForMarginOrShadow to OutsetWithCornerCorrection, as it better describes what it does. See w3c/csswg-drafts#12896 Bug: 448651073 Change-Id: I1eaca184c94bf9ad5b7c37a2091eb1f428406efc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7013748 Reviewed-by: Kyle Charbonneau <kylecharchromium.org> Commit-Queue: Noam Rosenthal <nrosenthalgoogle.com> Reviewed-by: Philip Rogers <pdrchromium.org> Cr-Commit-Position: refs/heads/main{#1531048} -- wpt-commits: cc6a94ac8793499299b00dde8b97c41aa5c95216 wpt-pr: 55490 UltraBlame original commit: f8971006e2aa005cd335199615bb9b1c9c03e5f5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new adjustment makes the radius reduction factor in the minimum radius percentage of the corner, making it less pronounced the closer the corner's border-radius gets to 50%.
Closes #7103
Resolution: #7103 (comment)