Skip to content

Conversation

@noamr
Copy link
Collaborator

@noamr noamr commented Oct 2, 2025

The new adjustment makes the radius reduction factor in the minimum radius percentage of the corner, making it less pronounced the closer the corner's border-radius gets to 50%.

Closes #7103
Resolution: #7103 (comment)

The new adjustment makes the radius reduction factor in the
minimum radius percentage of the corner, making it less pronounced
the closer the corner's border-radius gets to 50%.

Closes w3c#7103
Resolution: w3c#7103 (comment)
@noamr noamr requested a review from fantasai October 2, 2025 11:55
@noamr noamr changed the title [css-background-3] Adjust border-radius outset adjustment [css-background-3] Adjust border-radius outset correction Oct 2, 2025
@noamr noamr requested a review from tabatkins October 3, 2025 20:30
@noamr
Copy link
Collaborator Author

noamr commented Oct 13, 2025

Review anyone? @tabatkins ?

chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 16, 2025
Use the new coverage-based algorithm that takes into account the
percentage of the radius from the overall width/height.

Also rename OutsetForMarginOrShadow to OutsetWithCornerCorrection,
as it better describes what it does.

See w3c/csswg-drafts#12896

Bug: 448651073

Change-Id: I1eaca184c94bf9ad5b7c37a2091eb1f428406efc
@tabatkins tabatkins merged commit 433051c into w3c:main Oct 16, 2025
1 check passed
@noamr noamr deleted the corner-shaping-new-algo branch October 16, 2025 19:46
aarongable pushed a commit to chromium/chromium that referenced this pull request Oct 16, 2025
Use the new coverage-based algorithm that takes into account the
percentage of the radius from the overall width/height.

Also rename OutsetForMarginOrShadow to OutsetWithCornerCorrection,
as it better describes what it does.

See w3c/csswg-drafts#12896

Bug: 448651073

Change-Id: I1eaca184c94bf9ad5b7c37a2091eb1f428406efc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7013748
Reviewed-by: Kyle Charbonneau <kylechar@chromium.org>
Commit-Queue: Noam Rosenthal <nrosenthal@google.com>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1531048}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 16, 2025
Use the new coverage-based algorithm that takes into account the
percentage of the radius from the overall width/height.

Also rename OutsetForMarginOrShadow to OutsetWithCornerCorrection,
as it better describes what it does.

See w3c/csswg-drafts#12896

Bug: 448651073

Change-Id: I1eaca184c94bf9ad5b7c37a2091eb1f428406efc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7013748
Reviewed-by: Kyle Charbonneau <kylechar@chromium.org>
Commit-Queue: Noam Rosenthal <nrosenthal@google.com>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1531048}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 16, 2025
Use the new coverage-based algorithm that takes into account the
percentage of the radius from the overall width/height.

Also rename OutsetForMarginOrShadow to OutsetWithCornerCorrection,
as it better describes what it does.

See w3c/csswg-drafts#12896

Bug: 448651073

Change-Id: I1eaca184c94bf9ad5b7c37a2091eb1f428406efc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7013748
Reviewed-by: Kyle Charbonneau <kylechar@chromium.org>
Commit-Queue: Noam Rosenthal <nrosenthal@google.com>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1531048}
jrguzman-ms pushed a commit to msft-mirror-aosp/platform.external.libchrome that referenced this pull request Oct 22, 2025
Use the new coverage-based algorithm that takes into account the
percentage of the radius from the overall width/height.

Also rename OutsetForMarginOrShadow to OutsetWithCornerCorrection,
as it better describes what it does.

See w3c/csswg-drafts#12896

Bug: 448651073

Change-Id: I1eaca184c94bf9ad5b7c37a2091eb1f428406efc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7013748
Reviewed-by: Kyle Charbonneau <kylechar@chromium.org>
Commit-Queue: Noam Rosenthal <nrosenthal@google.com>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1531048}


CrOS-Libchrome-Original-Commit: fd139d5d7350a66492181c3291784fb29c6b74d9
lando-prod-mozilla bot pushed a commit to mozilla-firefox/firefox that referenced this pull request Oct 24, 2025
…estonly

Automatic update from web-platform-tests
Apply new border-radius/spread algo

Use the new coverage-based algorithm that takes into account the
percentage of the radius from the overall width/height.

Also rename OutsetForMarginOrShadow to OutsetWithCornerCorrection,
as it better describes what it does.

See w3c/csswg-drafts#12896

Bug: 448651073

Change-Id: I1eaca184c94bf9ad5b7c37a2091eb1f428406efc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7013748
Reviewed-by: Kyle Charbonneau <kylechar@chromium.org>
Commit-Queue: Noam Rosenthal <nrosenthal@google.com>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1531048}

--

wpt-commits: cc6a94ac8793499299b00dde8b97c41aa5c95216
wpt-pr: 55490
i3roly pushed a commit to i3roly/firefox-dynasty that referenced this pull request Oct 25, 2025
…estonly

Automatic update from web-platform-tests
Apply new border-radius/spread algo

Use the new coverage-based algorithm that takes into account the
percentage of the radius from the overall width/height.

Also rename OutsetForMarginOrShadow to OutsetWithCornerCorrection,
as it better describes what it does.

See w3c/csswg-drafts#12896

Bug: 448651073

Change-Id: I1eaca184c94bf9ad5b7c37a2091eb1f428406efc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7013748
Reviewed-by: Kyle Charbonneau <kylechar@chromium.org>
Commit-Queue: Noam Rosenthal <nrosenthal@google.com>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1531048}

--

wpt-commits: cc6a94ac8793499299b00dde8b97c41aa5c95216
wpt-pr: 55490
mertcanaltin pushed a commit to mertcanaltin/wpt that referenced this pull request Oct 26, 2025
Use the new coverage-based algorithm that takes into account the
percentage of the radius from the overall width/height.

Also rename OutsetForMarginOrShadow to OutsetWithCornerCorrection,
as it better describes what it does.

See w3c/csswg-drafts#12896

Bug: 448651073

Change-Id: I1eaca184c94bf9ad5b7c37a2091eb1f428406efc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7013748
Reviewed-by: Kyle Charbonneau <kylechar@chromium.org>
Commit-Queue: Noam Rosenthal <nrosenthal@google.com>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1531048}
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 29, 2025
…estonly

Automatic update from web-platform-tests
Apply new border-radius/spread algo

Use the new coverage-based algorithm that takes into account the
percentage of the radius from the overall width/height.

Also rename OutsetForMarginOrShadow to OutsetWithCornerCorrection,
as it better describes what it does.

See w3c/csswg-drafts#12896

Bug: 448651073

Change-Id: I1eaca184c94bf9ad5b7c37a2091eb1f428406efc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7013748
Reviewed-by: Kyle Charbonneau <kylecharchromium.org>
Commit-Queue: Noam Rosenthal <nrosenthalgoogle.com>
Reviewed-by: Philip Rogers <pdrchromium.org>
Cr-Commit-Position: refs/heads/main{#1531048}

--

wpt-commits: cc6a94ac8793499299b00dde8b97c41aa5c95216
wpt-pr: 55490

UltraBlame original commit: f8971006e2aa005cd335199615bb9b1c9c03e5f5
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 29, 2025
…estonly

Automatic update from web-platform-tests
Apply new border-radius/spread algo

Use the new coverage-based algorithm that takes into account the
percentage of the radius from the overall width/height.

Also rename OutsetForMarginOrShadow to OutsetWithCornerCorrection,
as it better describes what it does.

See w3c/csswg-drafts#12896

Bug: 448651073

Change-Id: I1eaca184c94bf9ad5b7c37a2091eb1f428406efc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7013748
Reviewed-by: Kyle Charbonneau <kylecharchromium.org>
Commit-Queue: Noam Rosenthal <nrosenthalgoogle.com>
Reviewed-by: Philip Rogers <pdrchromium.org>
Cr-Commit-Position: refs/heads/main{#1531048}

--

wpt-commits: cc6a94ac8793499299b00dde8b97c41aa5c95216
wpt-pr: 55490

UltraBlame original commit: f8971006e2aa005cd335199615bb9b1c9c03e5f5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[css-backgrounds-3][css-borders-4] The shape of box-shadow should be a circle for a box with border-radius:50% and big spread

3 participants