Skip to content

[cssom-view] Minor editorial fixes. #12933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 11, 2025
Merged

[cssom-view] Minor editorial fixes. #12933

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0af5f64
[cssom-view] Escape Promise<undefined> properly.
emilio Oct 11, 2025
9dcfc72
[cssom-view] Fix up other bikeshed issues.
emilio Oct 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 21 additions & 20 deletions cssom-view-1/Overview.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,13 +446,13 @@ the following steps must be run:
1. Let <var>scrollPromise</var> be a new {{Promise}}.
1. Return <var>scrollPromise</var>, and run the remaining steps <a>in parallel</a>.
1. If the user agent honors the 'scroll-behavior' property and one of the following is true:
<ul>
<li><var>behavior</var> is "<code>auto</code>" and <var>element</var> is not null and its computed value of the
'scroll-behavior' property is ''scroll-behavior/smooth'', or
<li><var>behavior</var> is <code>smooth</code>
</ul>
then perform a <a>smooth scroll</a> of <var>box</var> to <var>position</var>;
otherwise, perform an <a>instant scroll</a> of <var>box</var> to <var>position</var>.
<ul>
<li><var>behavior</var> is "<code>auto</code>" and <var>element</var> is not null and its computed value of the
'scroll-behavior' property is ''scroll-behavior/smooth'', or
<li><var>behavior</var> is <code>smooth</code>
</ul>
then perform a <a>smooth scroll</a> of <var>box</var> to <var>position</var>;
otherwise, perform an <a>instant scroll</a> of <var>box</var> to <var>position</var>.
1. Wait until either the position has finished updating, or <var>scrollPromise</var> has been resolved.
1. If <var>scrollPromise</var> is still in the pending state:
1. If the scroll position changed as a result of this call, emit the <a event>scrollend</a> event.
Expand Down Expand Up @@ -590,12 +590,12 @@ partial interface Window {
[Replaceable] readonly attribute double pageXOffset;
[Replaceable] readonly attribute double scrollY;
[Replaceable] readonly attribute double pageYOffset;
Promise<undefined> scroll(optional ScrollToOptions options = {});
Promise<undefined> scroll(unrestricted double x, unrestricted double y);
Promise<undefined> scrollTo(optional ScrollToOptions options = {});
Promise<undefined> scrollTo(unrestricted double x, unrestricted double y);
Promise<undefined> scrollBy(optional ScrollToOptions options = {});
Promise<undefined> scrollBy(unrestricted double x, unrestricted double y);
Promise&lt;undefined> scroll(optional ScrollToOptions options = {});
Promise&lt;undefined> scroll(unrestricted double x, unrestricted double y);
Promise&lt;undefined> scrollTo(optional ScrollToOptions options = {});
Promise&lt;undefined> scrollTo(unrestricted double x, unrestricted double y);
Promise&lt;undefined> scrollBy(optional ScrollToOptions options = {});
Promise&lt;undefined> scrollBy(unrestricted double x, unrestricted double y);

// client
[Replaceable] readonly attribute long screenX;
Expand Down Expand Up @@ -1320,13 +1320,13 @@ partial interface Element {

boolean checkVisibility(optional CheckVisibilityOptions options = {});

Promise<undefined> scrollIntoView(optional (boolean or ScrollIntoViewOptions) arg = {});
Promise<undefined> scroll(optional ScrollToOptions options = {});
Promise<undefined> scroll(unrestricted double x, unrestricted double y);
Promise<undefined> scrollTo(optional ScrollToOptions options = {});
Promise<undefined> scrollTo(unrestricted double x, unrestricted double y);
Promise<undefined> scrollBy(optional ScrollToOptions options = {});
Promise<undefined> scrollBy(unrestricted double x, unrestricted double y);
Promise&lt;undefined> scrollIntoView(optional (boolean or ScrollIntoViewOptions) arg = {});
Promise&lt;undefined> scroll(optional ScrollToOptions options = {});
Promise&lt;undefined> scroll(unrestricted double x, unrestricted double y);
Promise&lt;undefined> scrollTo(optional ScrollToOptions options = {});
Promise&lt;undefined> scrollTo(unrestricted double x, unrestricted double y);
Promise&lt;undefined> scrollBy(optional ScrollToOptions options = {});
Promise&lt;undefined> scrollBy(unrestricted double x, unrestricted double y);
attribute unrestricted double scrollTop;
attribute unrestricted double scrollLeft;
readonly attribute long scrollWidth;
Expand Down Expand Up @@ -1851,6 +1851,7 @@ means to run these steps:
1. Let <var>scrollPromise</var> be a new {{Promise}}.
1. Return <var>scrollPromise</var>, and run the remaining steps <a>in parallel</a>.
1. Resolve <var>scrollPromise</var> when all {{Promise}}s in <var>ancestorPromises</var> have settled.

</div>

<div algorithm>
Expand Down