Skip to content

[css-animation-1] Handle <string> values in keyframes-name as identitiers #12985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2025
Merged

[css-animation-1] Handle <string> values in keyframes-name as identitiers #12985

merged 1 commit into from
Oct 20, 2025

Conversation

@javifernandez
Copy link
Contributor

@javifernandez javifernandez commented Oct 20, 2025 •
edited by tabatkins
Loading

Per resolution:

#2435 (comment)

  1. Accept <string> or <custom-ident> as we currently do.
  2. If <string> is one of the CSS-wide keywords or "default" then it is invalid (at parse / variable-resolution time) as per the rules for custom-idents: https://www.w3.org/TR/css-values-3/#custom-idents
  3. When serializing, if the value doesn't have whitespace(??) serialize without quotes (i.e. as ), otherwise serialize as <string>.

Fixes issues #2435 and #7762

@javifernandez javifernandez marked this pull request as draft October 20, 2025 21:24
@javifernandez javifernandez force-pushed the animation-name-strings branch from 9dff371 to 14d9631 Compare October 20, 2025 22:43
@javifernandez javifernandez marked this pull request as ready for review October 20, 2025 22:43
@tabatkins tabatkins merged commit 643d5f0 into main Oct 20, 2025
1 check passed
This was referenced Oct 20, 2025
Open
Open
Open
@bkardell
Copy link
Contributor

bkardell commented Oct 21, 2025

I'm really not sure this should have been merged, there are definitely some disagreements. This would make 2 otherwise interoperable implementations incorrect on quoted names, right? And @nt1m is making a case on one of the linked issues that it doesn't make sense.

Also, minor nit but

hence parsed as invalid if is one of

doesn't this miss the work "it"?

javifernandez added a commit that referenced this pull request Oct 21, 2025
@javifernandez
Revert "Handle <string> values in keyframes-name rules. (#12985)"
0f1fe17 
This reverts commit 643d5f0.
@javifernandez javifernandez mentioned this pull request Oct 21, 2025
Merged
javifernandez added a commit that referenced this pull request Oct 21, 2025
@javifernandez
Revert "Handle <string> values in keyframes-name rules. (#12985)"
4001c55 
This reverts commit 643d5f0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tabatkins tabatkins tabatkins approved these changes

@fantasai fantasai Awaiting requested review from fantasai

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@javifernandez @bkardell @tabatkins