[css-nesting-1] Fix linking of <<scope-start>> #12991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`<scope-start>` is a production, and should use the production markup `<<scope-start>>`. Fixes this error: LINE 1347:22: ''...'' shorthand (opened on 1347:7) was closed, but there were still open elements inside of it.
mirisuzanne
approved these changes
Oct 21, 2025
|
That change looks right to me. (I'm not an editor of CSS Nesting) |
|
Ah, I thought you were. My mistake. |
Neither am I, though I was told by @tabatkins that obvious bugfixes don't require review. And this change definitely falls into that category. Sebastian |
|
Yes, please just merge obvious bugfixes, no need for review. If you're not sure it's an obvious bugfix, then you can ping for review. |
In case that was directed at me: I don't have write access to this repo. So I do need a review, effectively. |
|
Ah, fair. Well, you can just ask for a merge, then, so people feel ok just pressing the button. ^_^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<scope-start>is a production, and should use the production markup<<scope-start>>.Fixes this error:
LINE 1347:22: ''...'' shorthand (opened on 1347:7) was closed,
but there were still open elements inside of it.