Skip to content

[css-fonts-5] Define behavior for <meta text-scale> from #12380 #13052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

[css-fonts-5] Define behavior for <meta text-scale> from #12380 #13052

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8d5f5e2
no bs edits
davidsgrogan Nov 2, 2025
18f2f8b
Small revisions
davidsgrogan Nov 4, 2025
b729d74
after review round 1
davidsgrogan Nov 5, 2025
0206973
Apply suggestions from code review
davidsgrogan Nov 9, 2025
c287984
Josh's suggestions from review round 1
davidsgrogan Nov 12, 2025
f6d1a0c
full example
davidsgrogan Nov 14, 2025
3716341
add 'environment variable' following ''preferred-text-scale''
davidsgrogan Nov 14, 2025
828b01e
put Value Definitions back in the right place
davidsgrogan Nov 22, 2025
65d7813
add link to scaling rate issue
davidsgrogan Nov 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Josh Tumath <josh.tumath@bbc.co.uk>
  • Loading branch information
@davidsgrogan @JoshTumath
davidsgrogan and JoshTumath authored Nov 9, 2025
commit 0206973f173ed1def5e30abe40730b608c717248
4 changes: 2 additions & 2 deletions css-fonts-5/Overview.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ The recognized keywords in the [=text-scale=]
<{meta}> element are:

<dl>
<dt><dfn for="text-scale"><code>legacy</code></dfn></dt>
<dt><dfn for="text-scale">legacy</dfn></dt>
<dd>''env()/preferred-text-scale'' returns the user's OS-level font factor on mobile,
but 1 on desktop.
The document's initial font size only incorporates UA-level font preferences.
Expand All @@ -106,7 +106,7 @@ the user has chosen from any settings <i>provided by the user agent</i>.
The ''preferred-text-scale'' value must be 1 on desktop platforms.
Copy link
Contributor

@JoshTumath JoshTumath Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wherever you reference the preferred-text-scale env(), maybe it should be prefixed with 'environment variable' in the prose. Since this is not the css-env spec, it's not clear that you're referencing an env().

Copy link
Member Author

@davidsgrogan davidsgrogan Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bikeshed linkifies ''preferred-text-scale'' to https://drafts.csswg.org/css-env-1/#valdef-env-preferred-text-scale. Do you think that's sufficient? (I couldn't tell if you already knew the linkification part)

Copy link
Contributor

@JoshTumath JoshTumath Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm using the Bikeshed preview tool and I'm aware of the linkification, but still think it would be useful to say something like:

The ''preferred-text-scale'' environment variable value must be 1 on desktop platforms.

That matches how it's worded in the css-env-1 spec as well.

Copy link
Member Author

@davidsgrogan davidsgrogan Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, ok, will do.

Copy link
Member Author

@davidsgrogan davidsgrogan Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And aside, how do you use that preview tool for this PR? Do you put something into the "Load from URL" box?
Screenshot 2025-11-14 at 1 49 53 PM

Copy link
Member Author

@davidsgrogan davidsgrogan Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

@JoshTumath JoshTumath Nov 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. And yeah I just pasted the URL of the 'raw' version of the BS file on GitHub.

On mobile:
<ul>
<li>if the operating system provides a text scale setting AND the UA hasn't already applied that factor to the initial font size, ''env()/preferred-text-scale'' returns the mulitplier that the user has chosen in the operating system's text scale setting.
<li>if the operating system provides a text scale setting AND the UA hasn't already applied that factor to the initial font size, ''env()/preferred-text-scale'' returns the multiplier that the user has chosen in the operating system's text scale setting.

Note: As of this writing, all combinations of Android, iOS, Gecko, WebKit, Blink satisfy this first condition.

Expand Down