[css-navigation-1] Add :link-to() pseudo-class (with navigation-param() function #13134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…() function). This adds an initial proposal for the :link-to() pseudo-class and a navigation-param() function that goes inside of it. This also refactors some of the invocations of the URL pattern "match" algorithm to structure the parameters the way the algorithm expects (and be a little bit clearer that a base URL doesn't need to be provided).
noamr
reviewed
Nov 22, 2025
| [ "and" <<navigation-param-expression>> ]* | ||
| <dfn><<navigation-param-or>></dfn> = <<navigation-param-expression>> | ||
| [ "or" <<navigation-param-expression>> ]* | ||
| <dfn><<navigation-param>></dfn> = <<navigation-param-key-value>> | <<navigation-param-function>> |
Collaborator
There was a problem hiding this comment.
Does this mean that the syntax is :link-to(route-name with navigation-param(movie-id)) / :link-to(route-name with movie-id: 123) or some such?
Member
Author
There was a problem hiding this comment.
I think it currently requires one more set of () for whatever is after the with, but otherwise yes. (This is changeable, though!)
noamr
approved these changes
Nov 22, 2025
Collaborator
noamr
left a comment
There was a problem hiding this comment.
LGTM
Let's have some strawman proposals as part of the spec and revise them as we go along.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an initial proposal for the :link-to() pseudo-class and a navigation-param() function that goes inside of it.
This also refactors some of the invocations of the URL pattern "match" algorithm to structure the parameters the way the algorithm expects (and be a little bit clearer that a base URL doesn't need to be provided).