[css-fonts-4] Create proper types for <absolute-size> and <relative-size>#13321
Merged
Conversation
…e-size>` Both `<absolute-size>` and `<relative-size>` were defined as values for `font-size`, but that made Bikeshed link the terms to the underlying type definitions in CSS2. That's confusing for readers following links because the definition of `<absolute-size>` in CSS2 does not have `xxx-large`. That also confuses other spec processing tools, see w3c/webref#1794 This update turns the value definitions into proper type definitions, which will override those defined in CSS2, and make links to `<absolute-size>` and `<relative-size>` target the local definitions.
Contributor
|
@tidoust Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both
<absolute-size>and<relative-size>were defined as values forfont-size, but that made Bikeshed link the terms to the underlying type definitions in CSS2.That's confusing for readers following links because the definition of
<absolute-size>in CSS2 does not havexxx-large. That also confuses other spec processing tools, see w3c/webref#1794This update turns the value definitions into proper type definitions, which will override those defined in CSS2, and make links to
<absolute-size>and<relative-size>target the local definitions.