[css-inline-3] Unify dominant-baseline and alignment-baseline values. #13327#13456
Merged
[css-inline-3] Unify dominant-baseline and alignment-baseline values. #13327#13456
Conversation
SebastianZ
approved these changes
Feb 7, 2026
sdahill927hcc
approved these changes
Feb 7, 2026
sdahill927hcc
approved these changes
Feb 7, 2026
sdahill927hcc
approved these changes
Feb 7, 2026
sdahill927hcc
approved these changes
Feb 8, 2026
Contributor
Author
|
@SebastianZ Looks like the IPR commitment was successful (thanks @svgeesus for helping with that) so this should be ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #13327 by pulling out the baseline metric keywords (except
autoandbaseline) into a new type called<baseline-metric>, and used that in bothdominant-baselineandalignment-baseline. The immediate effect of this is to add thehangingkeyword toalignment-baselinewhich previously did not have it.This change is modeled after the existing
<text-edge>type and associated language of theline-fit-edgeandtext-box-edgeproperties.