[css-content] Fix syntaxes according to CSS Values and Units grammar #1381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tabatkins
requested changes
May 15, 2017
css-content/Overview.bs
Outdated
|
|
||
| <pre class="prod"> | ||
| <dfn><<leader-type>></dfn> = leader( dotted | solid | space | <<string>>); | ||
| <dfn><<leader()>></dfn> = leader( <<leader-type>> ) |
Member
There was a problem hiding this comment.
This should be defined as just <dfn>leader()</dfn>. (The grammar non-terminal automagically works when the function is defined normally.)
Contributor
Author
There was a problem hiding this comment.
It's confusing a bit, but looks like I was wrong. Fixed.
|
|
||
| <pre class="prod"> | ||
| <dfn><<target>></dfn> = [ ''target-counter()'' | ''target-counters()'' | ''target-text()'' ] | ||
| <dfn><<target>></dfn> = <<target-counter()>> | <<target-counters()>> | <<target-text()>> |
Member
There was a problem hiding this comment.
Same deal as previous function.
Contributor
Author
There was a problem hiding this comment.
target is not a function. I missed something?
Member
There was a problem hiding this comment.
Yeah, sorry, was overcorrecting.
css-content/Overview.bs
Outdated
|
|
||
| <pre class="prod"> | ||
| <dfn>target-counter()</dfn> = target-counter( [ <<string>> | <<url>> ] , <<custom-ident>> [ , <<counter-style>> ]? ) | ||
| <dfn><<target-counter()>></dfn> = target-counter( [ <<string>> | <<url>> ] , <<custom-ident>> , <<counter-style>>? ) |
css-content/Overview.bs
Outdated
|
|
||
| <pre class="prod"> | ||
| <dfn>target-counters()</dfn> = target-counter( [ <<string>> | <<url>> ] , <<custom-ident>> , <<string>> [ , <<counter-style>> ]? ) | ||
| <dfn><<target-counters()>></dfn> = target-counters( [ <<string>> | <<url>> ] , <<custom-ident>> , <<string>> , <<counter-style>>? ) |
css-content/Overview.bs
Outdated
|
|
||
| <pre class="prod"> | ||
| <dfn id="target-text-function">target-text()</dfn> = target-text( [ <<string>> | <<url>> ] [ , [ content | before | after | first-letter] ]? ) | ||
| <dfn id="target-text-function"><<target-text()>></dfn> = target-text( [ <<string>> | <<url>> ] , [ content | before | after | first-letter ]? ) |
css-content/Overview.bs
Outdated
|
|
||
| <pre class="prod"> | ||
| <dfn>string()</dfn> = string( <<custom-ident>> , [ first | start | last | first-except ]? ) | ||
| <dfn><<string()>></dfn> = string( <<custom-ident>> , [ first | start | last | first-except ]? ) |
css-content/Overview.bs
Outdated
|
|
||
| <pre class="prod"> | ||
| <dfn>content()</dfn> = content( [text | before | after | first-letter | marker ]? ) | ||
| <dfn><<content()>></dfn> = content( [ text | before | after | first-letter | marker ] ) |
Member
There was a problem hiding this comment.
same.
Also, don't remove the ?, that's a significant and important bit. (It allows the "If no value is specified" bit a few lines later down.)
Contributor
Author
There was a problem hiding this comment.
Thank you for clarification, I missed this. Fixed.
This was referenced May 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix and simplify syntaxes, see #663 for details