-
Notifications
You must be signed in to change notification settings - Fork 791
[css-grid-1][css-grid-2] Clarify that Grid can fragment within rows #13870 #13871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fantasai
wants to merge
1
commit into
w3c:main
Choose a base branch
from
fantasai:grid-fragment-rows
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Items may not actually be fragmented as a result. For example, say you have a definite row size of 50px and all items in the row are 25px. If say your fragmentainer has a block size of 40px, the row fragments, but the items remain unfragmented. (Technically in this case, implementation-wise it would be the container breaking (since rows don't create fragments themselves), but we can think of it as the row being fragmented).
In another example, say your row is definitely sized to 25px but your item is 50px, the item will fragment, but your row will not (and the item will overflow the row as usual).
Also, if an item had a forced break before the fragmentainer boundary, it may have broken at an earlier point than the row would have.
So to summarize, item fragmentation is technically independent of the row. If a row is intrinsically sized, though, the breaking of items can impact the breaking of a row.
I'm thinking perhaps we'll need to word this in a way that is separated from items. Maybe something along the lines of "A grid track may fragment, similar to a grid item, if its block size does not fit within the fragmentainer boundary. Fragmentation breaks within a grid item..."