[view-transitions-2] Do not access box fragments on things that don't fragment#13972
Open
Psychpsyo wants to merge 1 commit into
Open
[view-transitions-2] Do not access box fragments on things that don't fragment#13972Psychpsyo wants to merge 1 commit into
Psychpsyo wants to merge 1 commit into
Conversation
… fragment Neither elements nor captured elements can fragment. Only boxes do that. I'm making this care about the principal box here, since fragmenting any other boxes that might be created for an element inside of its principal box will also fragment the principal box.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11991
Neither elements nor captured elements can fragment. Only boxes do that.
I'm making this care about the principal box here, since fragmenting any other boxes that might be created for an element inside of its principal box will also fragment the principal box (to my knowledge).
If I'm wrong on that, we might need to check what exactly is intended here.