Skip to content

[cssom][cssom-view] Update editors #1816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 14, 2017
Merged

[cssom][cssom-view] Update editors #1816

merged 1 commit into from
Sep 14, 2017

Conversation

@zcorpan
Copy link
Contributor

@zcorpan zcorpan commented Sep 14, 2017

frivoal
frivoal approved these changes Sep 14, 2017
View reviewed changes
Copy link
Collaborator

@frivoal frivoal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sad but true.

The comma has a special meaning for bikeshed, resulting in "NOBODY" working for "OOPS!", which is rendered as "NOBODY (OOPS!)" rather than preserving the original punctuation, but that looks fine too, sure LGTM.

@zcorpan
Copy link
Contributor Author

zcorpan commented Sep 14, 2017

"NOBODY (OOPS!)" was the intended result. 🙂

@svgeesus svgeesus merged commit f9495cb into master Sep 14, 2017
@zcorpan zcorpan deleted the zcorpan/rm-editor branch September 14, 2017 18:16
@syncbot syncbot restored the zcorpan/rm-editor branch October 4, 2017 13:02
@plinss plinss deleted the zcorpan/rm-editor branch November 7, 2017 22:51
@syncbot syncbot restored the zcorpan/rm-editor branch November 7, 2017 23:38
@plinss plinss deleted the zcorpan/rm-editor branch November 7, 2017 23:50
@syncbot syncbot restored the zcorpan/rm-editor branch November 8, 2017 00:01
@plinss plinss deleted the zcorpan/rm-editor branch November 8, 2017 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frivoal frivoal frivoal approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zcorpan @frivoal @svgeesus