[css-syntax] Trim whitespace from the beginning/ending of a declarati… #1986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on's value. Fixes #774.
tabatkins
added a commit
to tabatkins/wpt
that referenced
this pull request
Nov 18, 2017
kalenobr
suggested changes
Dec 2, 2017
| Create a new declaration | ||
| with its name set to the value of the <a>current input token</a> | ||
| and its value initially set to the empty list. | ||
| and its value initially set to the empty [=list=]. |
Contributor
|
Is there any reason why this hasn't been merged yet? It seems there is a testcase ready to be merged in WPT (with rebasing) at tabatkins/wpt@1e27529, and other WPT testcases can be adjusted at the same time as well. |
Member
Author
|
I never merged it because I never successfully got wpt running so that I could run and lint the test. ^_^ But if it's fine, I'm happy to merge. |
Contributor
|
Travis helpfully runs & lints tests for PRs to WPT, so you should be able to check by rebasing and opening a pull request. I was just mentioning this as I was going through some of the Variables tests, which are partially incorrect per the current spec (or partially correct), but would be affected by this spec change. |
Member
Author
|
Ooh, didn't know. Will do so now. |
tabatkins
added a commit
to tabatkins/wpt
that referenced
this pull request
Apr 19, 2018
tabatkins
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 27, 2018
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
May 2, 2018
Automatic update from web-platform-testsMerge pull request #10539 from tabatkins/css-syntax-whitespace Test for w3c/csswg-drafts#1986 -- wpt-commits: cc364d6f98b111e488aa1d88064af21566ec4184 wpt-pr: 10539
|
Either I'm reading it incorrectly or CSS Custom Property tests haven't been updated to account for this change; I submitted web-platform-tests/wpt#34880. |
cdumez
added a commit
to cdumez/web-platform-tests
that referenced
this pull request
Nov 29, 2022
There was a spec change a few years ago requiring spaces around CSS declaration's value to be trimmed: w3c/csswg-drafts#1986. The discussion leading to this spec change: w3c/csswg-drafts#774. This closes issue web-platform-tests#34880.
cdumez
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 29, 2022
There was a spec change a few years ago requiring spaces around CSS declaration's value to be trimmed: w3c/csswg-drafts#1986. The discussion leading to this spec change: w3c/csswg-drafts#774. This closes issue #34880.
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Dec 11, 2022
…ing values, a=testonly Automatic update from web-platform-tests CSS variables tests should require trimming values (#37239) There was a spec change a few years ago requiring spaces around CSS declaration's value to be trimmed: w3c/csswg-drafts#1986. The discussion leading to this spec change: w3c/csswg-drafts#774. This closes issue #34880. -- wpt-commits: c96c37fa465273e3e87bdaa79b157884417129b7 wpt-pr: 37239
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Dec 14, 2022
…ing values, a=testonly Automatic update from web-platform-tests CSS variables tests should require trimming values (#37239) There was a spec change a few years ago requiring spaces around CSS declaration's value to be trimmed: w3c/csswg-drafts#1986. The discussion leading to this spec change: w3c/csswg-drafts#774. This closes issue #34880. -- wpt-commits: c96c37fa465273e3e87bdaa79b157884417129b7 wpt-pr: 37239
jwidar
pushed a commit
to jwidar/LatencyZeroGithub
that referenced
this pull request
Sep 16, 2025
Automatic update from web-platform-testsMerge pull request #10539 from tabatkins/css-syntax-whitespace Test for w3c/csswg-drafts#1986 -- wpt-commits: cc364d6f98b111e488aa1d88064af21566ec4184 wpt-pr: 10539
jwidar
pushed a commit
to jwidar/LatencyZeroGithub
that referenced
this pull request
Sep 16, 2025
…ing values, a=testonly Automatic update from web-platform-tests CSS variables tests should require trimming values (#37239) There was a spec change a few years ago requiring spaces around CSS declaration's value to be trimmed: w3c/csswg-drafts#1986. The discussion leading to this spec change: w3c/csswg-drafts#774. This closes issue #34880. -- wpt-commits: c96c37fa465273e3e87bdaa79b157884417129b7 wpt-pr: 37239
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…on's value. Fixes #774.
Needs a testcase before merging.