-
Notifications
You must be signed in to change notification settings - Fork 759
Fixed link errors (part of issue #208) #212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,7 +10,7 @@ ED: https://drafts.csswg.org/css-logical-props/ | |
| Editor: Rossen Atanassov, Microsoft, ratan@microsoft.com | ||
| Editor: Elika J. Etemad / fantasai, Invited Expert, http://fantasai.inkedblade.net/contact | ||
| Abstract: This module introduces logical properties and values that provide the author with the ability to control layout through logical, rather than physical, direction and dimension mappings. The module defines logical properties and values for the features defined in [CSS21]. These properties are writing-mode relative equivalents of their corresponding physical properties. | ||
| Ignored Terms: div, dl, dfn | ||
| Ignored Terms: div, dl, dfn, block-start, block-end, inline-start, inline-end, start, end | ||
| Link Defaults: css21 (property) width/height/min-width/min-height/max-width/max-height | ||
| </pre> | ||
|
|
||
|
|
@@ -22,7 +22,7 @@ Introduction</h1> | |
| This mapping controls the interpretation of logical keywords and properties. | ||
|
|
||
| <h2 id="logical-controls"> | ||
| Logical Directional Values: ''block-start'', ''block-end'', ''inline-start'', ''inline-end''</h2> | ||
| Logical Directional Values: 'block-start', 'block-end', 'inline-start', 'inline-end'</h2> | ||
|
||
|
|
||
| Properties that accept physical directional keyword values | ||
| ('top', 'bottom', 'left', or 'right') are redefined | ||
|
|
@@ -60,7 +60,7 @@ Logical Values for the 'float' and 'clear' Properties</h3> | |
| New values: inline-start | inline-end | ||
| </pre> | ||
|
|
||
| Issue: Is this a 2-directional property? Should these just be ''start''/''end''? | ||
| Issue: Is this a 2-directional property? Should these just be 'start'/'end'? | ||
|
|
||
| <h3 id="text-align"> | ||
| Logical Values for the 'text-align' Property</h3> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These shouldn't be ignored; they're terms that need to link up in this spec. If the definitions are broken that's something to be fixed, not ignored.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I've addressed this and the next comment in 4447eec.
My thought was that they are already defined in the prose. Those values affect many different properties in several specs. So I wonder how that can be defined correctly (without mentioning every single affected property).
Sebastian