[css-align-3] Add left|right to *-position grammar #2169
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds the `left` and `right` keywords to the grammar terms `<self-position>` and `<content-position>`. That addition to the grammar brings it into sync with the existing spec prose, which already includes `left` and `right` among the *positional alignment* keywords collection, and states, “Two grammar terms are used to denote this collection of values: `<self-position>` [and] `<content-position>`”.
|
Yeah, I talked with @fantasai about this and she reminded me that we very explicitly did not want left/right in justify-content, nor the align-* properties; they're only intended for inline layout. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the
leftandrightkeywords to the grammar terms<self-position>and<content-position>.That addition to the grammar brings it into sync with the existing spec prose,
which already includes
leftandrightamong the positional alignmentkeywords collection, and states, “Two grammar terms are used to denote this
collection of values:
<self-position>[and]<content-position>”.